-
Notifications
You must be signed in to change notification settings - Fork 73
[SYNPY-1697] Add Create JSON Schema tutorial #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
BryanFauble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bit of work left on these. Thank you for the initial stab at this!
Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
| ``` | ||
|
|
||
| To create a JSON Schema you need a data-model, and the data-types you want to create. | ||
| The data-model must be in either CSV or JSON-LD form. The data model maybe a local path or a URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The data-model must be in either CSV or JSON-LD form. The data model maybe a local path or a URL. | |
| The data-model must be in either CSV or JSON-LD form. The data model may be a local path or a URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to also include an example of what the URL looks like by using one of the published data models that we have available to us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my last comment @andrewelamb ^
Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
| ```python | ||
| {!docs/tutorials/python/tutorial_scripts/schema_operations.py!lines=15-23} | ||
| ``` | ||
| You should see the first JSON Schema for the datatype(s) you selected printed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include the example output of what would be printed here given the example URL data model that we will use? That way folks have a bit of context of what to expect.
BryanFauble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! Thanks for the changes.
Problem:
Schematic code was extracted to the Curator extension(minus the cli commands). There is no instructiosn for how to crate a JSON Schema using curator extention as a python library.
Solution:
Add a short tutorial for how to create json shemas. This could be replaced or added onto a tutorial for creating json schema via CLI in the future.