Skip to content

Conversation

@epichb
Copy link

@epichb epichb commented Dec 6, 2024

The configured replicaCount value was not used in the deployment config. This PR aims to remediate this issue.

@epichb epichb requested a review from SQLJames as a code owner December 6, 2024 11:44
@Kariton
Copy link
Contributor

Kariton commented Dec 7, 2024

i think a more appropriate way would be to remove the value from helm values and keep it hardcoded in the deployment.
factorio does not support running multiple instances at the same time.

@epichb
Copy link
Author

epichb commented Dec 7, 2024

I see your point. My original use case was scaling down the instance when nobody was on the server, but that is probably better done by scaling manually and (in my case) excluding replica count from the Argo sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants