Task/71 get service locations2 #79
Open
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissa3000
requested review from
delbertlegg,
mihiramin89,
mollyhenderson,
mycarrysun and
vijayyadav06
vijayyadav06
approved these changes
Feb 13, 2020
Member
|
Hey! Sorry for taking so long to check this out. This looks like what we would want, but I think (based on what we briefly discussed last week) we don't actually need this endpoint 😬 I believe the concept of an "agency" isn't needed any more, since "location" covers all the information we need. I'll be opening a UI PR shortly to remove this call. We can discuss there, in case there's anything I'm missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is what we need from the agency request, but feel free to make suggestions/comments because I'm still trying to figure it out.