mfd: max14577: Fix wakeup source leaks on device unbind

krzk · lag-linaro · commit d905d06e64b0 · 2025-05-23T08:49:08.000+01:00
Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250406-mfd-device-wakekup-leak-v1-3-318e14bdba0a@linaro.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
@@ -456,6 +456,7 @@ static void max14577_i2c_remove(struct i2c_client *i2c)
 {
 	struct max14577 *max14577 = i2c_get_clientdata(i2c);
 
+	device_init_wakeup(max14577->dev, false);
 	mfd_remove_devices(max14577->dev);
 	regmap_del_irq_chip(max14577->irq, max14577->irq_data);
 	if (max14577->dev_type == MAXIM_DEVICE_TYPE_MAX77836)

Original file line number	Diff line number	Diff line change
`@@ -456,6 +456,7 @@ static void max14577_i2c_remove(struct i2c_client *i2c)`
`456`	`456`	`{`
`457`	`457`	`struct max14577 *max14577 = i2c_get_clientdata(i2c);`
`458`	`458`
	`459`	`+ device_init_wakeup(max14577->dev, false);`
`459`	`460`	`mfd_remove_devices(max14577->dev);`
`460`	`461`	`regmap_del_irq_chip(max14577->irq, max14577->irq_data);`
`461`	`462`	`if (max14577->dev_type == MAXIM_DEVICE_TYPE_MAX77836)`