mfd: as3722: Fix wakeup source leaks on device unbind

krzk · lag-linaro · commit 2c8294c9aaa0 · 2025-05-23T08:49:07.000+01:00
Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250406-mfd-device-wakekup-leak-v1-2-318e14bdba0a@linaro.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/mfd/as3722.c b/drivers/mfd/as3722.c
@@ -394,7 +394,9 @@ static int as3722_i2c_probe(struct i2c_client *i2c)
 		return ret;
 	}
 
-	device_init_wakeup(as3722->dev, true);
+	ret = devm_device_init_wakeup(as3722->dev);
+	if (ret)
+		return dev_err_probe(as3722->dev, ret, "Failed to init wakeup\n");
 
 	dev_dbg(as3722->dev, "AS3722 core driver initialized successfully\n");
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -394,7 +394,9 @@ static int as3722_i2c_probe(struct i2c_client *i2c)`
`394`	`394`	`return ret;`
`395`	`395`	`}`
`396`	`396`
`397`		`- device_init_wakeup(as3722->dev, true);`
	`397`	`+ ret = devm_device_init_wakeup(as3722->dev);`
	`398`	`+ if (ret)`
	`399`	`+ return dev_err_probe(as3722->dev, ret, "Failed to init wakeup\n");`
`398`	`400`
`399`	`401`	`dev_dbg(as3722->dev, "AS3722 core driver initialized successfully\n");`
`400`	`402`	`return 0;`