mfd: rt5033: Fix wakeup source leaks on device unbind

krzk · lag-linaro · commit 82ae581e56c3 · 2025-05-23T08:49:12.000+01:00
Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250406-mfd-device-wakekup-leak-v1-7-318e14bdba0a@linaro.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
@@ -98,7 +98,11 @@ static int rt5033_i2c_probe(struct i2c_client *i2c)
 		return ret;
 	}
 
-	device_init_wakeup(rt5033->dev, rt5033->wakeup);
+	if (rt5033->wakeup) {
+		ret = devm_device_init_wakeup(rt5033->dev);
+		if (ret)
+			return dev_err_probe(rt5033->dev, ret, "Failed to init wakeup\n");
+	}
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,11 @@ static int rt5033_i2c_probe(struct i2c_client *i2c)`
`98`	`98`	`return ret;`
`99`	`99`	`}`
`100`	`100`
`101`		`- device_init_wakeup(rt5033->dev, rt5033->wakeup);`
	`101`	`+ if (rt5033->wakeup) {`
	`102`	`+ ret = devm_device_init_wakeup(rt5033->dev);`
	`103`	`+ if (ret)`
	`104`	`+ return dev_err_probe(rt5033->dev, ret, "Failed to init wakeup\n");`
	`105`	`+ }`
`102`	`106`
`103`	`107`	`return 0;`
`104`	`108`	`}`