mfd: max8925: Fix wakeup source leaks on device unbind

krzk · lag-linaro · commit fd37695dae09 · 2025-05-23T08:49:11.000+01:00
Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250406-mfd-device-wakekup-leak-v1-6-318e14bdba0a@linaro.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
@@ -201,6 +201,7 @@ static void max8925_remove(struct i2c_client *client)
 	struct max8925_chip *chip = i2c_get_clientdata(client);
 
 	max8925_device_exit(chip);
+	device_init_wakeup(&client->dev, false);
 	i2c_unregister_device(chip->adc);
 	i2c_unregister_device(chip->rtc);
 }

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ static void max8925_remove(struct i2c_client *client)`
`201`	`201`	`struct max8925_chip *chip = i2c_get_clientdata(client);`
`202`	`202`
`203`	`203`	`max8925_device_exit(chip);`
	`204`	`+ device_init_wakeup(&client->dev, false);`
`204`	`205`	`i2c_unregister_device(chip->adc);`
`205`	`206`	`i2c_unregister_device(chip->rtc);`
`206`	`207`	`}`