Skip to content

Conversation

@schell
Copy link
Collaborator

@schell schell commented Oct 29, 2025

These changes fix #121 by separating --package/-p from --shader-crate args and performing a lookup using cargo_metadata to resolve the package name to the shader crate path.

Fixes #121.

@schell
Copy link
Collaborator Author

schell commented Oct 29, 2025

@tombh it looks like maybe the tests are failing on an old dependency - is this another case where we need to run cargo update or similar?

@tombh
Copy link
Collaborator

tombh commented Oct 29, 2025

Here's the error, it's the same for both the 0.8.0 and 0.9.0 job failures:

error: package `indexmap v2.12.0` cannot be built because it requires rustc 1.82 or newer, while the currently active rustc version is 1.71.0-nightly
Either upgrade to rustc 1.82 or newer, or use
cargo update -p indexmap@2.12.0 --precise ver

But I notice that our lockfile has:

[[package]]
name = "indexmap"
version = "2.6.0"

So I can't remember why those old builds might be skipping the lockfile 🤔

@Firestar99
Copy link
Member

see #123

Copy link
Member

@Firestar99 Firestar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor performance thing

@schell schell force-pushed the fix/cargo-p-shader-crate branch from c3f1b51 to fe9047f Compare November 6, 2025 02:52
@schell schell requested a review from Firestar99 November 6, 2025 03:00
@Firestar99
Copy link
Member

Let's merge it as is, even with failing CI. I assume it is ready to review since you asked for one from me, even though the PR itself is still set to WIP.

@Firestar99 Firestar99 marked this pull request as ready for review November 6, 2025 09:40
@schell schell merged commit bf24eb6 into main Nov 17, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo-gpu can't find Cargo.toml from a package specified with cargo build -p {package}

4 participants