-
Notifications
You must be signed in to change notification settings - Fork 195
README: Fedora: Add gcc, gcc-c++, cargo, and awk
#4255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Running At the end. Not sure if that ( It seems to build fine in WSL. |
philberty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cant remove the README
7faa1de to
97e2de7
Compare
|
Oops. I'm not sure how that happened. I used GitHub's web VS Code UI to edit Anyways, I just revived |
philberty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
You need to fix your commit message to pass our commit checker. you can use the tools to setup git gcc-commit-mklog in contrib |
ChangeLog: * README.md: Add Fedora WSL deps. Signed-off-by: Osama Albahrani <osalbahr@gmail.com>
97e2de7 to
6aa1fba
Compare
CohenArthur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks @osalbahr! |
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rustpasses locally (N/A)clang-format(N/A)gcc/testsuite/rust/(N/A)Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
This commit adds dependencies needed for
../gccrs/configure --prefix=$HOME/gccrs-install --disable-bootstrap --enable-multilib --enable-languages=rust(from the README) in a freshFedoraLinux-43WSL. Most are also needed in afedoracontainer (the exception isawk; it's present in the container but not WSL).In other words, this commit fixes the following
configureerrors (truncated and combined):The goal is to eventually package
gccrsin Copr (Fedora's AUR). Finding all the dependencies is a first step.Signed-off-by: Osama Albahrani <osalbahr@gmail.com>