Skip to content

Update tests to expect query layering #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2025
Merged

Update tests to expect query layering #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ce31a1
Update tests to expect query layering
mmcgr Oct 20, 2025
5b9a93c
linting
mmcgr Oct 20, 2025
67cbac6
but why
mmcgr Oct 20, 2025
cc052b6
Revert "but why"
mmcgr Oct 20, 2025
2b20538
Disable query layering dependent tests
mmcgr Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 1 addition & 73 deletions src/results/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,7 @@ import {
} from '../testUtils';
import { ResultTable } from './resultTable';
import { getDisplayValue } from './resultUtils';
import {
miscValueTypeTests,
specializationTests,
standardTypeTests,
valueTypeSpecializationTests,
valueTypeTests,
} from './tests';
import { specializationTests, standardTypeTests } from './tests';

describe('Integration', () => {
const engineName = getEngineName();
Expand Down Expand Up @@ -92,70 +86,4 @@ describe('Integration', () => {
});
});
});

describe('Rel to JS value types', () => {
setup();

valueTypeTests.forEach(test => {
const testFn = test.skip ? it.skip : test.only ? it.only : it;

testFn(`should handle ${test.name} in value type`, async () => {
const result = await client.exec(databaseName, engineName, test.query);
const table = new ResultTable(result.results[0]).sliceColumns(1);
const typeDefs = table.typeDefs();
const values = table.get(0);
const displayValues = values?.map((v, i) =>
getDisplayValue(typeDefs[i], v),
);

expect(typeDefs).toEqual(test.typeDefs);
expect(values).toEqual(test.values);
expect(displayValues).toEqual(test.displayValues);
});
});
});

describe('Rel to JS value types misc', () => {
setup();

miscValueTypeTests.forEach(test => {
const testFn = test.skip ? it.skip : test.only ? it.only : it;

testFn(`should handle ${test.name} value type`, async () => {
const result = await client.exec(databaseName, engineName, test.query);
const table = new ResultTable(result.results[0]).sliceColumns(1);
const typeDefs = table.typeDefs();
const values = table.get(0);
const displayValues = values?.map((v, i) =>
getDisplayValue(typeDefs[i], v),
);

expect(typeDefs).toEqual(test.typeDefs);
expect(values).toEqual(test.values);
expect(displayValues).toEqual(test.displayValues);
});
});
});

describe('Rel to JS value types specialization', () => {
setup();

valueTypeSpecializationTests.forEach(test => {
const testFn = test.skip ? it.skip : test.only ? it.only : it;

testFn(`should handle ${test.name} value type`, async () => {
const result = await client.exec(databaseName, engineName, test.query);
const table = new ResultTable(result.results[0]).sliceColumns(1);
const typeDefs = table.typeDefs();
const values = table.get(0);
const displayValues = values?.map((v, i) =>
getDisplayValue(typeDefs[i], v),
);

expect(typeDefs).toEqual(test.typeDefs);
expect(values).toEqual(test.values);
expect(displayValues).toEqual(test.displayValues);
});
});
});
});
Loading
Loading