-
Notifications
You must be signed in to change notification settings - Fork 35
Add path defaults to all commands #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Defaulting to the root path makes sense imo. This PR, however, also bundles a new command, |
| keys ``args`` | ||
|
|
||
|
|
||
| ### jsonmgetl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate PR
| pieces.append(str_path(path)) | ||
| return self.execute_command('JSON.MGET', *pieces) | ||
|
|
||
| def jsonmgetl(self, keys=[], path=Path.rootPath()): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate PR - jsonmget's signature should change (breaking bw compat) to jsonmget(self, path=Path.rootPath(), keys=[], *args)
for ease of use, the default path would always be the root as defined by
Path.rootPath()