Review jsonpath_rs #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Pop last token from json path 2. Check if the json path is static path (lead to single result) 3. Check the amount of tokens on the json path
Author
|
Replaced by #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few comments up til now:
full_scanorall? (currently it seems to be allowed by the grammar)flat_arrays_on_filter- you mean we should not iterate all array entries, but only the relevant ones (e.g., if using a union, no need to iterate all?)And not sure I understand, for example, in
calc_internalinRule::filterin theelseclause we passtrueand not the param we gotflat_arrays_on_filterfilter_inner,filter_nested) so they are commented out to be reviewed later