feat: Add copy-to-clipboard button for table cells #13
+467
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lkrzyzanek could you please review? Thanks |
Contributor
Author
|
@jschuler ready for review, added test coverage |
- Add CopyButton component with PatternFly icons (CopyIcon/CheckIcon) - Automatically detects copyable columns (id, name, url, email, cluster) - Shows on row hover with smooth animations - Visual feedback: icon changes and animates on successful copy - Includes CSS for hover states, transitions, and success animation - Uses modern Clipboard API with error handling - Non-intrusive UX: hidden until hover, doesn't interfere with row clicks Tested in OCM Genie POC with cluster IDs, names, and URLs.
- Add 20 new test cases for copy-to-clipboard functionality - Test copyable column detection (id, name, url, email, cluster) - Test non-copyable columns don't get copy buttons - Test clipboard API integration with mocked navigator.clipboard - Test visual feedback (CheckIcon on success) - Test event propagation blocking to prevent row clicks - Test multiple copy buttons across rows and columns - Test case-insensitive column name detection - Test cell wrapper structure and accessibility (aria-label) - Test with empty values and numeric values - All 25 tests passing ✓
vishsanghishetty
force-pushed
the
feat/copy-button
branch
from
15df507 to
2d65a41
Compare
Contributor
Author
|
Closing this PR in favor of #22. Joachim's implementation using PatternFly's ClipboardCopy component is cleaner and more maintainable. The smart data-type detection is also better than my hardcoded column name approach. Thanks for the review and the improved solution! I learned a lot from comparing the two approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in OCM Genie POC with cluster IDs, names, and URLs.
