This repository was archived by the owner on Oct 1, 2018. It is now read-only.
feat(i18n): Setup ngx-translate in rxjs-docs #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup ngx-translate with english and russian languages Add language service Create language menu Add unit tests
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=========================================
+ Coverage 77.14% 79.9% +2.76%
=========================================
Files 15 17 +2
Lines 175 214 +39
Branches 7 9 +2
=========================================
+ Hits 135 171 +36
- Misses 40 41 +1
- Partials 0 2 +2
Continue to review full report at Codecov.
|
valorkin
approved these changes
Feb 14, 2018
Member
|
Looks pretty good. Thanks for the PR. Just a short question, how is this pr related to #144? |
Contributor
Author
ashwin-sureshkumar
approved these changes
Feb 14, 2018
Member
|
Ok get it. Thank you |
niklas-wortmann
approved these changes
Feb 14, 2018
Member
|
🤗 y'all! this is amazing! |
|
I'll follow up with the Chinest translation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup ngx-translate with English and Russian languages
Add language service
Create language menu
Add unit tests