Skip to content

Conversation

@jeffrapid
Copy link

No description provided.

@jeffrapid jeffrapid requested review from LMS007 and alexwalling May 4, 2022 17:29
@s-giovanni
Copy link
Contributor

s-giovanni commented May 4, 2022

We should remember to update the documentation once this goes in so that users are aware of the instance parameter that needs to be added in the GH action.

Additionally, do we want to default instance to rapidapi.com? Just thinking that the self-serve users may not be aware of what instance means. If this is already how it works, my apologies.

Add default as rapidapi if the parameter is not provided
@alexwalling
Copy link

@s-giovanni just added the change that should prevent existing integrations from breaking. Let me do another deeper dive before we merge though.

Copy link

@LMS007 LMS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at the working through this.

I also need to update the readme and we'll want to add a bit more functionality to include the POST vs GET options with a body payload for trigger overrides

I can take over from here!

const LOCATION = core.getInput('location');
console.log(`Executing In Location: ${LOCATION}`);

const INSTANCE = core.getInput('instance') || "rapidapi";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: define input in action.yml, possibly with a default "rapidapi.com"

core.group('Execute Test', async () => {
// 1. Trigger Test
const envString = ENVIRONMENT ? `&enviroment=${ENVIRONMENT}` : '';
const instance = INSTANCE;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we make this the full domain w/ .com then we can just call this DOMAIN

@LMS007
Copy link

LMS007 commented Nov 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants