Skip to content

Conversation

@epilk
Copy link

@epilk epilk commented Nov 29, 2025

SWDEV-555455

@epilk epilk requested review from kzhuravl and slinder1 November 29, 2025 04:16
@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@z1-cciauto
Copy link
Collaborator

Copy link

@slinder1 slinder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a plan for how to reapply permanently?

@epilk epilk merged commit aa47a98 into amd-staging Dec 4, 2025
10 checks passed
@epilk epilk deleted the fix-gdb-tests-staging branch December 4, 2025 20:00
@epilk
Copy link
Author

epilk commented Dec 4, 2025

Do we have a plan for how to reapply permanently?

We're going to need to change how we handle structure returns in device functions in clang for amdgcn and amdgcnspirv, since the ABI lowering in the backend shouldn't be depending on the IR type like it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants