Skip to content

Support args, command for helm chart #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support args, command for helm chart #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18287af
Set args, command for helm chart
kwang-park Apr 22, 2025
1c7fcbd
apply PR comment. add default values
kwang1121 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm/amd-gpu/templates/deviceplugin-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ spec:
containers:
- name: {{ .Chart.Name }}-dp-cntr
image: {{ .Values.dp.image.repository }}:{{ .Values.dp.image.tag | default .Chart.AppVersion }}
command:
{{- toYaml .Values.dp.command | nindent 12 }}
args:
{{- toYaml .Values.dp.args | nindent 12 }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
volumeMounts:
Expand Down
2 changes: 2 additions & 0 deletions helm/amd-gpu/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ dp:
repository: docker.io/rocm/k8s-device-plugin
# Overrides the image tag whose default is the chart appVersion.
tag: "1.31.0.6"
command: ["./k8s-device-plugin"]
args: ["-logtostderr=true", "-stderrthreshold=INFO", "-v=5"]
resources: {}
# Set daemonsets updateStrategy for device plugin
updateStrategy:
Expand Down