feat: Implement inner validation rules for Array columns #222
+79
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes the issue where
dy.Arraycolumns could not use validation rules on inner elements (e.g.,dy.Array(dy.Float64(nullable=False), shape=1024)raised "Validation rules on the inner type of Array are not yet supported"). Polars now supports.arr.eval(), making this implementable.Changes
Implementation (
dataframely/columns/array.py)validation_rules()method usingexpr.arr.eval(inner_expr).arr.all()to validate inner elements, mirroring theListimplementationvalidate_dtype()method comparing constructed dtypes directly to handle both flat and nested array representationsPolarsDataTypeimportTests (
tests/column_types/test_array.py)test_array_with_rulesfrom expecting ValueError to validating that inner rules worktest_nested_array_with_rulesfor nested array validationvalidation_maskimportExample usage:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.