Skip to content

Update string.py to use len_chars() instead of len_bytes() #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Update string.py to use len_chars() instead of len_bytes() #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dataframely/columns/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ def dtype(self) -> pl.DataType:
def validation_rules(self, expr: pl.Expr) -> dict[str, pl.Expr]:
result = super().validation_rules(expr)
if self.min_length is not None:
result["min_length"] = expr.str.len_bytes() >= self.min_length
result["min_length"] = expr.str.len_chars() >= self.min_length
if self.max_length is not None:
result["max_length"] = expr.str.len_bytes() <= self.max_length
result["max_length"] = expr.str.len_chars() <= self.max_length
if self.regex is not None:
result["regex"] = expr.str.contains(self.regex)
return result
Expand Down
Loading