Use a dialog to display the LargePortraitCard. #169

HaudinFlorence · 2024-10-30T13:40:14Z

Use a dialog to display the LargePortraitCard.

Should fix #129

vercel · 2024-10-30T13:40:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quantstack-github-io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 4, 2025 3:37pm

src/components/about/LargePortraitCard.tsx

afshin · 2025-07-04T08:58:40Z

src/components/about/LargePortraitCardPage.tsx

+        render={({ history, match }) => {
+          const { completeName } = match.params; /* extract the dynamic part from the url i.e. the completeName*/
+          const teamMembers = getTeamByPersonName(completeName);
+          const person = teamMembers.find((person) => person.completeName.replace(/\s+/g, '').normalize("NFD").replace(/[\u0300-\u036f]/g, '') === completeName);


Because you're doing this name string clean up step twice (with the replace(...) etc.), I would suggest either storing the cleaned up version as part of the person's JSON blob or writing a small utility function so that you're not duplicating this logic. (not a blocker for merging)

afshin · 2025-07-04T09:02:42Z

...gePortraitCard. by HaudinFlorence · Pull Request #169 · QuantStack_quantstack.github.io.html

What is this file? It seems like something that was not supposed to be in the PR?

To be fair, I don't know.

HaudinFlorence · 2025-07-04T09:29:47Z

@afshin Thanks for the review. I will take your comment into account

…yle.

… the dialog by clicking the overlay.

…es for the collaborators.

…act that the individual popup were not rendered on /about/person page when entering the corresponding url.

…page.

…ters. Add logics to not scroll systematically to the top of the page when changing from about page to portrait ones and reciprocally.

Co-authored-by: Afshin Taylor Darian <git@darian.link>

vercel bot deployed to Preview October 30, 2024 13:41 View deployment

HaudinFlorence changed the title ~~Use a dialog pop to display the LargePortraitCard.~~ Use a dialog to display the LargePortraitCard. Oct 30, 2024

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 4a056b3 to c56cda8 Compare October 30, 2024 13:47

vercel bot deployed to Preview October 30, 2024 13:47 View deployment

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from c56cda8 to 4f3d386 Compare October 30, 2024 16:56

vercel bot deployed to Preview October 30, 2024 16:58 View deployment

vercel bot deployed to Preview October 30, 2024 16:59 View deployment

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from c269866 to 5b58c1b Compare October 30, 2024 23:00

vercel bot deployed to Preview October 30, 2024 23:01 View deployment

vercel bot deployed to Preview October 31, 2024 11:13 View deployment

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from dfb33bd to 207e124 Compare October 31, 2024 11:36

vercel bot deployed to Preview October 31, 2024 11:37 View deployment

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 207e124 to 76faa10 Compare November 2, 2024 10:29

vercel bot deployed to Preview November 2, 2024 10:30 View deployment

vercel bot deployed to Preview November 2, 2024 10:44 View deployment

vercel bot deployed to Preview November 5, 2024 09:48 View deployment

vercel bot deployed to Preview November 7, 2024 18:10 View deployment

vercel bot deployed to Preview November 14, 2024 16:02 View deployment

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 26f909e to 74ae9c6 Compare June 23, 2025 16:15

vercel bot deployed to Preview June 23, 2025 16:17 View deployment

vercel bot had a problem deploying to Preview June 24, 2025 16:10 Failure

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 1bcc8b2 to 3756b2d Compare June 24, 2025 16:12

vercel bot had a problem deploying to Preview June 24, 2025 16:13 Failure

vercel bot had a problem deploying to Preview June 24, 2025 17:06 Failure

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from c893c09 to ea5a66f Compare June 24, 2025 17:40

vercel bot had a problem deploying to Preview June 24, 2025 17:42 Failure

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from ea5a66f to 8b48f2d Compare June 24, 2025 17:44

vercel bot had a problem deploying to Preview June 24, 2025 17:45 Failure

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 8b48f2d to 0b65a23 Compare June 24, 2025 17:48

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from d0a34c0 to b74d3a8 Compare June 26, 2025 10:25

vercel bot deployed to Preview June 26, 2025 10:26 View deployment

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from b74d3a8 to 50aab1e Compare June 26, 2025 13:26

vercel bot deployed to Preview June 26, 2025 13:27 View deployment

afshin reviewed Jul 4, 2025

View reviewed changes

src/components/about/LargePortraitCard.tsx Outdated Show resolved Hide resolved

afshin reviewed Jul 4, 2025

View reviewed changes

src/components/about/LargePortraitCard.tsx Outdated Show resolved Hide resolved

afshin reviewed Jul 4, 2025

View reviewed changes

vercel bot deployed to Preview July 4, 2025 14:05 View deployment

vercel bot had a problem deploying to Preview July 4, 2025 15:20 Failure

HaudinFlorence and others added 10 commits July 4, 2025 17:26

Resolve conflict on package-lock.json and package.json.

a376710

Add the pages for the different persons of the team and update the st…

3bfdda4

…yle.

Update SmallPortraitCardWithDialog to enable the possibility to close…

98b2868

… the dialog by clicking the overlay.

Update SmallPortraitCard and SmallPortraitCardWithDialog. Add the pag…

a5469c1

…es for the collaborators.

Remove console.log tests.

70c2ac3

Update the Distinction component.

a87bc1e

Update SmallPortraitCard and SmallPortraitCardWithDialog to fix the f…

0f6d3ac

…act that the individual popup were not rendered on /about/person page when entering the corresponding url.

Update SmallPortraitCard and AboutPage component except for index.ts …

eca331e

…page.

Fix issues related to last names like for those having special charac…

8cf196c

…ters. Add logics to not scroll systematically to the top of the page when changing from about page to portrait ones and reciprocally.

Apply suggestions from code review

209944a

Co-authored-by: Afshin Taylor Darian <git@darian.link>

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 8cca664 to c1a4bf9 Compare July 4, 2025 15:27

vercel bot had a problem deploying to Preview July 4, 2025 15:29 Failure

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from c1a4bf9 to 68cfaba Compare July 4, 2025 15:32

vercel bot deployed to Preview July 4, 2025 15:34 View deployment

Take review comments into account.

fcf6cf7

HaudinFlorence force-pushed the use_a_dialog_for_the_large_portrait_card branch from 68cfaba to fcf6cf7 Compare July 4, 2025 15:36

vercel bot deployed to Preview July 4, 2025 15:37 View deployment

HaudinFlorence merged commit 1031bf4 into QuantStack:master Jul 4, 2025
4 checks passed

HaudinFlorence deleted the use_a_dialog_for_the_large_portrait_card branch September 16, 2025 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use a dialog to display the LargePortraitCard. #169

Use a dialog to display the LargePortraitCard. #169

Uh oh!

HaudinFlorence commented Oct 30, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

afshin Jul 4, 2025

Uh oh!

afshin Jul 4, 2025

Uh oh!

HaudinFlorence Jul 4, 2025

Uh oh!

HaudinFlorence commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Use a dialog to display the LargePortraitCard. #169

Use a dialog to display the LargePortraitCard. #169

Uh oh!

Conversation

HaudinFlorence commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

afshin Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

afshin Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

HaudinFlorence Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

HaudinFlorence commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HaudinFlorence commented Oct 30, 2024 •

edited

Loading

vercel bot commented Oct 30, 2024 •

edited

Loading