Improve status output #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
requested changes
Nov 10, 2025
src/subcommand/status_subcommand.cpp
Outdated
| // } | ||
| // } | ||
|
|
||
| if (!sl.has_tobecommited_header() & (sl.has_notstagged_header() | sl.has_untracked_header())) |
Member
There was a problem hiding this comment.
I think these should be && and || (logical operators) rather than & and | (bitwise operators).
src/subcommand/status_subcommand.cpp
Outdated
| } | ||
| } | ||
|
|
||
| if (!sl.has_notstagged_header() & !sl.has_untracked_header()) |
ianthomas23
reviewed
Nov 10, 2025
src/subcommand/status_subcommand.cpp
Outdated
| // "No changes added to commit (use \"git add\" and/or \"git commit -a\")" | ||
| // (use \"git restore --staged <file>...\" to unstage)\n | ||
| // (use \"git reset HEAD <file>...\" to unstage)\n"; | ||
| const std::string ignored_header = "Ignored files:\n Ignored files:\n (use \"git add -f <file>...\" to include in what will be committed)\n"; |
Member
There was a problem hiding this comment.
Is the repeat of "Ignored files:\n" intended here?
Collaborator
Author
There was a problem hiding this comment.
No, I'll remove one. I'll also comment it as it's not used so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve status output: