Fix: Add trailing slash to quantecon-py URLs and upgrade quantecon-book-theme==0.13.2 (jupyterbook link fix) #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes redirect warnings from link checker by updating all https://quantecon.org/quantecon-py URLs to include trailing slash. Affected files: - finite_markov.md (10 links) - kalman.md (3 links) - linear_models.md (1 link) - lqcontrol.md (1 link) - markov_perf.md (3 links) - perm_income_cons.md (2 links) - rational_expectations.md (1 link) - samuelson.md (2 links) - troubleshooting.md (1 link) Closes #739 (redirect warnings)
|
📖 Netlify Preview Ready! Preview URL: https://pr-743--sunny-cactus-210e3e.netlify.app (56c429d) 📚 Changed Lecture Pages: finite_markov, kalman, linear_models, lqcontrol, markov_perf, perm_income_cons, rational_expectations, samuelson, troubleshooting |
Contributor
Author
|
@jstac this is ready for merge, but I will hold off until you've finished your current refactor round in case there are some files touched by this PR. |
Contributor
|
Thanks @mmcky , you are good to go |
Includes jupyterbook.org link fix (redirects to /v1/)
Contributor
Author
|
mmcky
changed the title
|
📖 Netlify Preview Ready! Preview URL: https://pr-743--sunny-cactus-210e3e.netlify.app (6c0449e) 📚 Changed Lecture Pages: finite_markov, kalman, linear_models, lqcontrol, markov_perf, perm_income_cons, rational_expectations, samuelson, troubleshooting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves link checker redirect warnings reported in #739.
Changes
1. Fixed quantecon-py URLs (24 links)
Updated all
https://quantecon.org/quantecon-pyURLs to include a trailing slash (https://quantecon.org/quantecon-py/) to eliminate redirect warnings.Files Updated:
finite_markov.mdkalman.mdmarkov_perf.mdsamuelson.mdperm_income_cons.mdlinear_models.mdlqcontrol.mdrational_expectations.mdtroubleshooting.md2. Updated quantecon-book-theme to v0.13.2
Updates theme from v0.13.1 to v0.13.2, which includes:
/en/stable/to/v1/)Link Checker Results
This PR should resolve all 12 redirect warnings from #739:
quantecon.org/quantecon-py→ fixed in source filesjupyterbook.org/en/stable/→ fixed in theme v0.13.2Notes on Remaining Errors
The 2 errors reported in #739 (
file:///...None) appear ingenindex.htmlandprf-prf.html. These are generated during the build process and may require investigation in sphinx-proof or the build configuration.Closes #739