feat: Add support for editing application info and new fields #2994

Lumabots · 2025-11-07T15:17:09Z

Introduces the AppInfo.edit coroutine to allow editing application settings. Updates AppInfo and related types to support new fields such as bot, flags, event webhooks, integration_types_config, and approximate_user_authorization_count. Also refactors type hints and improves handling of optional fields for better API compatibility.

Summary

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

Introduces the AppInfo.edit coroutine to allow editing application settings. Updates AppInfo and related types to support new fields such as bot, flags, event webhooks, integration_types_config, and approximate_user_authorization_count. Also refactors type hints and improves handling of optional fields for better API compatibility.

pycord-app · 2025-11-07T15:17:13Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2994/head:pr-2994
git checkout pr-2994

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2994/head

Soheab

Also missing docs for the new attributes.

discord/appinfo.py

Introduces the AppInfo.edit() method to allow editing application settings, including new and previously missing fields such as icon, cover_image, tags, install_params, integration_types_config, flags, event_webhooks_url, event_webhooks_status, and event_webhooks_types. Also adds related helper classes and properties for handling these fields and updates the CHANGELOG accordingly.

Copilot

Pull Request Overview

This pull request adds an AppInfo.edit() method for editing application settings and includes missing fields from the Discord API to the AppInfo class.

Key Changes:

Added AppInfo.edit() method to modify application settings via the Discord API
Added new fields to AppInfo including bot, event_webhooks_*, integration_types_config, and approximate_user_authorization_count
Restructured TypedDict definitions in discord/types/appinfo.py to better reflect the Discord API structure
Added IntegrationTypesConfig helper class for per-installation context configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
discord/types/appinfo.py	Restructured TypedDict definitions, changed from `User` to `PartialUser`, moved many fields to `NotRequired`, and added new type aliases for application integration types
discord/http.py	Added `edit_current_application()` HTTP method to support the new edit functionality
discord/client.py	Removed workaround for missing `rpc_origins` field and cleaned up unused imports
discord/appinfo.py	Added new `edit()` method, new fields and properties, `IntegrationTypesConfig` class, and `to_payload()` method for `AppInstallParams`
CHANGELOG.md	Documented the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

discord/appinfo.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Updated the AppInfo class to only accept bytes or None for the icon and cover_image parameters, removing support for str. This change clarifies the expected types and may prevent type-related errors.

…encing

Soheab · 2025-11-11T09:32:26Z

discord/appinfo.py

+            "approximate_user_authorization_count"
+        )
+        raw_flags = data.get("flags")
+        self._flags: int | None = raw_flags if isinstance(raw_flags, int) else None


What's the instance check for?

Soheab · 2025-11-11T09:35:25Z

discord/appinfo.py

+
+        .. versionadded:: 2.7
+
+    flags: Optional[:class:`ApplicationFlags`]


This is a property, which means it's self-documented AFAIK.

Soheab · 2025-11-11T09:36:01Z

discord/appinfo.py

        )

+    @property
+    def flags(self) -> ApplicationFlags | None:


Missing versionadded string

Soheab · 2025-11-11T09:36:11Z

discord/appinfo.py

+            return None
+        return ApplicationFlags._from_value(self._flags)
+
+    async def edit(


Missing versionadded string

Soheab · 2025-11-11T09:36:37Z

discord/appinfo.py

+
+        Edit the current application's settings.
+
+        This method wraps the Edit Current Application endpoint and returns the updated application info.


Is this necessary?

Soheab · 2025-11-11T09:37:49Z

discord/appinfo.py

+        Parameters
+        ----------
+        description: Optional[:class:`str`]
+            The new application description. Pass ``None`` to clear.


"The new ... or ``None`` to clear" would be better wording, I think?

Soheab · 2025-11-11T09:39:10Z

discord/appinfo.py

+        owner_data = data.get("owner")
+        self.owner: User | None = (
+            state.create_user(owner_data) if owner_data is not None else None
+        )


This is inconsistent with how it's done for the bot attribute below

Soheab · 2025-11-11T09:41:02Z

discord/appinfo.py

-        self.tags: list[str] | None = data.get("tags", [])
+        self.tags: list[str] = data.get("tags", [])


Maybe it was None because it could have a value of null? Should it maybe do or [] to be sure?

Soheab · 2025-11-11T09:42:02Z

discord/client.py

Why was any of this done?

Soheab · 2025-11-11T09:43:26Z

discord/appinfo.py

+        self.integration_types_config: dict[int, dict[str, object] | None] | None = (
+            data.get("integration_types_config")
+        )


Any reason the IntegrationTypesConfig object below isn't used here?

Lumabots requested a review from a team as a code owner November 7, 2025 15:17

pullapprove4 bot requested a review from Paillat-dev November 7, 2025 15:17

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Nov 7, 2025

style(pre-commit): auto fixes from pre-commit.com hooks

2f54fe7

Lumabots changed the title ~~Add support for editing application info and new fields~~ feat: Add support for editing application info and new fields Nov 7, 2025

Paillat-dev added hold: changelog This pull request is missing a changelog entry hold: testing This pull request requires further testing priority: low Low Priority labels Nov 7, 2025

Soheab reviewed Nov 7, 2025

View reviewed changes

discord/appinfo.py Show resolved Hide resolved

discord/appinfo.py Outdated Show resolved Hide resolved

Lumabots requested review from a team as code owners November 7, 2025 18:00

Lumabots requested review from DA-344, Icebluewolf and Lulalaby November 7, 2025 18:00

style(pre-commit): auto fixes from pre-commit.com hooks

bfa2940

Lumabots requested a review from Copilot November 7, 2025 18:01

Copilot AI reviewed Nov 7, 2025

View reviewed changes

Lumabots and others added 9 commits November 7, 2025 19:08

Update discord/appinfo.py

9893239

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update discord/appinfo.py

884cd6c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update discord/appinfo.py

41f12a2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update discord/appinfo.py

714c68a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update discord/appinfo.py

734b5ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update discord/appinfo.py

49c90b9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Restrict icon and cover_image types to bytes or None

76eb883

Updated the AppInfo class to only accept bytes or None for the icon and cover_image parameters, removing support for str. This change clarifies the expected types and may prevent type-related errors.

style(pre-commit): auto fixes from pre-commit.com hooks

bd91789

feat(emoji): add mention property to BaseEmoji for easier emoji refer…

7e5ff54

…encing

Lumabots added 2 commits November 7, 2025 20:28

Merge branch 'appinf' of https://github.com/Lumabots/pycord into appinf

6fc48da

Merge branch 'master' into appinf

bde7ec3

Lumabots requested a review from Soheab November 11, 2025 09:20

Lumabots removed the hold: changelog This pull request is missing a changelog entry label Nov 11, 2025

Soheab requested changes Nov 11, 2025

View reviewed changes

pullapprove4 bot removed the PA: All Contributors pending label Nov 11, 2025


		.. versionadded:: 2.7

		flags: Optional[:class:`ApplicationFlags`]


		Edit the current application's settings.

		This method wraps the Edit Current Application endpoint and returns the updated application info.

		self.tags: list[str] \| None = data.get("tags", [])
		self.tags: list[str] = data.get("tags", [])

Uh oh!

feat: Add support for editing application info and new fields #2994

Are you sure you want to change the base?

feat: Add support for editing application info and new fields #2994

Conversation

Lumabots commented Nov 7, 2025

Summary

Information

Checklist

Uh oh!

pycord-app bot commented Nov 7, 2025

Uh oh!

Soheab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Soheab Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Soheab Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Soheab Nov 11, 2025 •

edited

Loading

Soheab Nov 11, 2025 •

edited

Loading