feat(estimators, optimizers): switch to generics #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xImoZA
force-pushed
the
feat(core)/switch-to-generics
branch
from
fc27d30 to
fcffc43
Compare
xImoZA
force-pushed
the
feat(estimators-optimizers)/switch-to-generics
branch
from
0607c2a to
7faec1a
Compare
xImoZA
force-pushed
the
feat(estimators-optimizers)/switch-to-generics
branch
from
7faec1a to
9df7b32
Compare
xImoZA
force-pushed
the
feat(core)/switch-to-generics
branch
from
fa9cbae to
cd36859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the estimators and optimizers modules to use generic numeric types and improves numerical stability.
Implementation:
Generic Typing: Refactored estimators and optimizers classes to use typing.Generic with a TypeVar("DType").
Numerical Stability: Implemented logic to automatically recalculate with higher precision when numerical overflow is detected.
Test Coverage: Added additional test cases to significantly improve code coverage.
Type Safety: Added tests for return values to ensure type correctness.