-
Notifications
You must be signed in to change notification settings - Fork 86
Remove external untokenize package. Use tokenize from the Python standard library. #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is required for Python 3.14. The Tested with docker run -it python:3.14 bash
cd /tmp/
git clone https://github.com/tdenewiler/docformatter.git
cd docformatter
git checkout untokenize-std-lib
pip install tox
tox -e py314All tests are passing. If you stay on |
|
I ran the tox tests on Python 3.10, 3.11, 3.12, 3.13, and 3.14. |
|
The key insight here is that FWIW I recommend using |
|
+1 for removing this unused dependency |
|
@weibullguy Hopefully this is a very clear "merge", and a release to fix 3.14 would be welcome |
|
I'll probably look into the pydocstyle plugin for ruff. It supports a |
Does this plugin format docstrings or just verify them against various standards? |
|
FWIW even with this PR, on 3.14 docformatter adds extraneous newlines. |
No description provided.