Handle cmdlet invocation exception in analysis service

Author: Kapil Borle

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -6,9 +6,9 @@
 using Microsoft.PowerShell.EditorServices.Utility;
 using System;
 using System.Linq;
-using System.Management.Automation.Runspaces;
 using System.Threading.Tasks;
 using Microsoft.PowerShell.EditorServices.Console;
+using System.Management.Automation.Runspaces;
 using System.Management.Automation;
 using System.Collections.Generic;
 using System.Text;
@@ -342,13 +342,21 @@ private PSObject[] InvokePowerShell(string command, IDictionary<string, object>
                     powerShell.AddParameter(kvp.Key, kvp.Value);
                 }
 
-                var result = powerShell.Invoke();
-                if (result == null)
+                var result = new PSObject[0];
+                try
+                {
+                    result = powerShell.Invoke()?.ToArray();
+                }
+                catch (CmdletInvocationException ex)
                 {
-                    return new PSObject[0];
+                    // We do not want to crash EditorServices for exceptions caused by cmdlet invocation.
+                    // Two main reasons that cause the exception are:
+                    // * PSCmdlet.WriteOutput being called from another thread than Begin/Process
+                    // * CompositionContainer.ComposeParts complaining that "...Only one batch can be composed at a time"
+                    Logger.Write(LogLevel.Error, ex.Message);
                 }
 
-                return result.ToArray(); ;
+                return result;
             }
         }