Invoke PS synchronously in AnlysisService

Author: Kapil Borle

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -332,13 +332,6 @@ private async Task<PSObject[]> GetDiagnosticRecordsAsync<TSettings>(
         }
 
         private PSObject[] InvokePowerShell(string command, IDictionary<string, object> paramArgMap)
-        {
-            var task = InvokePowerShellAsync(command, paramArgMap);
-            task.Wait();
-            return task.Result;
-        }
-
-        private async Task<PSObject[]> InvokePowerShellAsync(string command, IDictionary<string, object> paramArgMap)
         {
             using (var powerShell = System.Management.Automation.PowerShell.Create())
             {
@@ -349,7 +342,7 @@ private async Task<PSObject[]> InvokePowerShellAsync(string command, IDictionary
                     powerShell.AddParameter(kvp.Key, kvp.Value);
                 }
 
-                var result = await Task.Factory.FromAsync(powerShell.BeginInvoke(), powerShell.EndInvoke);
+                var result = powerShell.Invoke();
                 if (result == null)
                 {
                     return new PSObject[0];
@@ -359,6 +352,15 @@ private async Task<PSObject[]> InvokePowerShellAsync(string command, IDictionary
             }
         }
 
+        private async Task<PSObject[]> InvokePowerShellAsync(string command, IDictionary<string, object> paramArgMap)
+        {
+            var task = Task.Run(() => {
+                return InvokePowerShell(command, paramArgMap);
+            });
+
+            return await task;
+        }
+
         #endregion //private methods
     }
 }