Selectively enable and fix a few more rules

Author: andyleejordan

.editorconfig

@@ -57,6 +57,12 @@ dotnet_diagnostic.CA1506.severity = warning
 dotnet_diagnostic.CA1507.severity = error
 # CA1508: Avoid dead conditional code
 dotnet_diagnostic.CA1508.severity = error
+# CA1802: Use Literals Where Appropriate
+dotnet_diagnostic.CA1802.severity = error
+# CA1805: Do not initialize unnecessarily.
+dotnet_diagnostic.CA1805.severity = error
+# CA1820: Test for empty strings using string length
+dotnet_diagnostic.CA1820.severity = error
 # CA1822: Mark members as static
 dotnet_diagnostic.CA1822.severity = error
 # CA1823: Avoid unused private fields
@@ -65,9 +71,13 @@ dotnet_diagnostic.CA1823.severity = error
 dotnet_diagnostic.CA2007.severity = error
 # CA2016: Forward the CancellationToken parameter to methods that take one
 dotnet_diagnostic.CA2016.severity = error
+# CA2213: Disposable fields should be disposed
+dotnet_diagnostic.CA2213.severity = error
 # CA2254: The logging message template should not vary between calls to 'LoggerExtensions.*'
 dotnet_diagnostic.CA2254.severity = silent
 
+# RCS1049: Simplify boolean comparison
+dotnet_diagnostic.RCS1049.severity = error
 # RCS1102: Make class static
 dotnet_diagnostic.RCS1102.severity = error
 # RCS1139: Add summary element to documentation comment

PowerShellEditorServices.Common.props

@@ -14,6 +14,7 @@
     <!-- See: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview -->
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    <!-- TODO: Enable <AnalysisMode>All</AnalysisMode> -->
     <!-- See: https://docs.microsoft.com/en-us/dotnet/core/compatibility/sdk/6.0/implicit-namespaces -->
     <DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
   </PropertyGroup>

src/PowerShellEditorServices.Hosting/Configuration/EditorServicesConfig.cs

@@ -76,12 +76,12 @@ public EditorServicesConfig(
         /// <summary>
         /// Names of or paths to any additional modules to load on startup.
         /// </summary>
-        public IReadOnlyList<string> AdditionalModules { get; set; } = null;
+        public IReadOnlyList<string> AdditionalModules { get; set; }
 
         /// <summary>
         /// Flags of features to enable on startup.
         /// </summary>
-        public IReadOnlyList<string> FeatureFlags { get; set; } = null;
+        public IReadOnlyList<string> FeatureFlags { get; set; }
 
         /// <summary>
         /// The console REPL experience to use in the integrated console
@@ -97,12 +97,12 @@ public EditorServicesConfig(
         /// <summary>
         /// Configuration for the language server protocol transport to use.
         /// </summary>
-        public ITransportConfig LanguageServiceTransport { get; set; } = null;
+        public ITransportConfig LanguageServiceTransport { get; set; }
 
         /// <summary>
         /// Configuration for the debug adapter protocol transport to use.
         /// </summary>
-        public ITransportConfig DebugServiceTransport { get; set; } = null;
+        public ITransportConfig DebugServiceTransport { get; set; }
 
         /// <summary>
         /// PowerShell profile locations for Editor Services to use for its profiles.

src/PowerShellEditorServices.Hosting/Configuration/TransportConfig.cs

@@ -49,7 +49,7 @@ public sealed class StdioTransportConfig : ITransportConfig
 
         public string SessionFileTransportName => "Stdio";
 
-        public IReadOnlyDictionary<string, object> SessionFileEntries { get; } = null;
+        public IReadOnlyDictionary<string, object> SessionFileEntries { get; }
 
         public Task<(Stream inStream, Stream outStream)> ConnectStreamsAsync()
         {

src/PowerShellEditorServices/Hosting/EditorServicesServerFactory.cs

@@ -58,7 +58,8 @@ public static EditorServicesServerFactory Create(string logPath, int minimumLogL
             SelfLog.Enable(msg => Debug.WriteLine(msg));
 #endif
 
-            ILoggerFactory loggerFactory = new LoggerFactory().AddSerilog();
+            LoggerFactory loggerFactory = new();
+            loggerFactory.AddSerilog();
 
             // Hook up logging from the host so that its recorded in the log file
             hostLogger.Subscribe(new HostLoggerAdapter(loggerFactory));

src/PowerShellEditorServices/Server/PsesDebugServer.cs

@@ -124,6 +124,7 @@ public void Dispose()
             _debugAdapterServer.Dispose();
             _inputStream.Dispose();
             _outputStream.Dispose();
+            _loggerFactory.Dispose();
             _serverStopped.SetResult(true);
             // TODO: If the debugger has stopped, should we clear the breakpoints?
         }

src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs

@@ -136,7 +136,7 @@ public AnalysisService(
         public void StartScriptDiagnostics(
             ScriptFile[] filesToAnalyze)
         {
-            if (_configurationService.CurrentSettings.ScriptAnalysis.Enable == false)
+            if (!_configurationService.CurrentSettings.ScriptAnalysis.Enable)
             {
                 return;
             }
@@ -468,7 +468,7 @@ private static Hashtable GetCommentHelpRuleSettings(string helpLocation, bool fo
         }
 
         #region IDisposable Support
-        private bool disposedValue = false; // To detect redundant calls
+        private bool disposedValue; // To detect redundant calls
 
         protected virtual void Dispose(bool disposing)
         {

src/PowerShellEditorServices/Services/Analysis/PssaCmdletAnalysisEngine.cs

@@ -258,7 +258,7 @@ public Task<ScriptFileMarker[]> AnalyzeScriptAsync(string scriptContent, Hashtab
         public PssaCmdletAnalysisEngine RecreateWithRules(string[] rules) => new(_logger, _analysisRunspacePool, _pssaModuleInfo, rules);
 
         #region IDisposable Support
-        private bool disposedValue = false; // To detect redundant calls
+        private bool disposedValue; // To detect redundant calls
 
         protected virtual void Dispose(bool disposing)
         {

src/PowerShellEditorServices/Services/PowerShell/Utility/ErrorRecordExtensions.cs

@@ -12,7 +12,7 @@ namespace Microsoft.PowerShell.EditorServices.Services.PowerShell.Utility
 {
     internal static class ErrorRecordExtensions
     {
-        private static readonly Action<PSObject> s_setWriteStreamProperty = null;
+        private static readonly Action<PSObject> s_setWriteStreamProperty;
 
         [SuppressMessage("Performance", "CA1810:Initialize reference type static fields inline", Justification = "cctor needed for version specific initialization")]
         static ErrorRecordExtensions()

src/PowerShellEditorServices/Services/TextDocument/FoldingReference.cs

@@ -20,7 +20,7 @@ internal class FoldingReference : IComparable<FoldingReference>, IEquatable<Fold
         /// <summary>
         /// The zero-based character offset from where the folded range starts. If not defined, defaults to the length of the start line.
         /// </summary>
-        public int StartCharacter { get; set; } = 0;
+        public int StartCharacter { get; set; }
 
         /// <summary>
         /// The zero-based line number where the folded range ends.
@@ -30,7 +30,7 @@ internal class FoldingReference : IComparable<FoldingReference>, IEquatable<Fold
         /// <summary>
         /// The zero-based character offset before the folded range ends. If not defined, defaults to the length of the end line.
         /// </summary>
-        public int EndCharacter { get; set; } = 0;
+        public int EndCharacter { get; set; }
 
         /// <summary>
         /// Describes the kind of the folding range such as `comment' or 'region'.