Enable maintainability rules (and sort rule list)

Author: andyleejordan

.editorconfig

@@ -22,6 +22,8 @@ csharp_style_expression_bodied_indexers = true
 csharp_style_expression_bodied_accessors = true
 csharp_style_expression_bodied_lambdas = when_on_single_line
 
+# TODO: Fix silenced and suggested rules!
+
 # CS0168: The variable 'var' is declared but never used
 dotnet_diagnostic.CS0168.severity = error
 # CS0169: The private field 'class member' is never used
@@ -30,10 +32,31 @@ dotnet_diagnostic.CS0169.severity = error
 dotnet_diagnostic.CS0219.severity = error
 # CS0414: The private field 'field' is assigned but its value is never used
 dotnet_diagnostic.CS0414.severity = error
+# CS0618: A class member was marked with the Obsolete attribute
+dotnet_diagnostic.CS0618.severity = suggestion
+# CS0649: Uninitialized private or internal field declaration that is never assigned a value
+dotnet_diagnostic.CS0649.severity = error
+# CS1998: This async method lacks 'await' operators and will run synchronously
+dotnet_diagnostic.CS1998.severity = suggestion
+# CS4014: Consider applying the await operator to the result of the call
+dotnet_diagnostic.CS4014.severity = suggestion
+
 # CA1067: Should override Equals because it implements IEquatable<T>
 dotnet_diagnostic.CA1067.severity = silent
 # CA1068: CancellationToken parameters must come last
 dotnet_diagnostic.CA1068.severity = error
+# CA1501: Avoid excessive inheritance
+dotnet_diagnostic.CA1501.severity = error
+# CA1502: Avoid excessive complexity
+dotnet_diagnostic.CA1502.severity = warning
+# CA1505: Avoid unmaintainable code
+dotnet_diagnostic.CA1505.severity = error
+# CA1506: Avoid excessive class coupling
+dotnet_diagnostic.CA1506.severity = warning
+# CA1507: Use nameof in place of string
+dotnet_diagnostic.CA1507.severity = error
+# CA1508: Avoid dead conditional code
+dotnet_diagnostic.CA1508.severity = error
 # CA1822: Mark members as static
 dotnet_diagnostic.CA1822.severity = error
 # CA1823: Avoid unused private fields
@@ -45,23 +68,6 @@ dotnet_diagnostic.CA2016.severity = error
 # CA2254: The logging message template should not vary between calls to 'LoggerExtensions.*'
 dotnet_diagnostic.CA2254.severity = silent
 
-# TODO: Enable all maintainability issues (dead code etc.) and enforce
-# See: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/maintainability-warnings
-dotnet_analyzer_diagnostic.category-Maintainability.severity = error
-
-# TODO: Fix all of these issues and explicitly ignore the intentional ones!
-
-# CA2016: Forward the CancellationToken parameter to methods that take one
-dotnet_diagnostic.CA2016.severity = error
-# CS0618: A class member was marked with the Obsolete attribute
-dotnet_diagnostic.CS0618.severity = suggestion
-# CS0649: Uninitialized private or internal field declaration that is never assigned a value
-dotnet_diagnostic.CS0649.severity = error
-# CS1998: This async method lacks 'await' operators and will run synchronously
-dotnet_diagnostic.CS1998.severity = suggestion
-# CS4014: Consider applying the await operator to the result of the call
-dotnet_diagnostic.CS4014.severity = suggestion
-
 # RCS1102: Make class static
 dotnet_diagnostic.RCS1102.severity = error
 # RCS1139: Add summary element to documentation comment

src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs

@@ -249,7 +249,7 @@ public async Task<IReadOnlyDictionary<string, IEnumerable<MarkerCorrection>>> Ge
         /// <param name="settings">The new language server settings.</param>
         public void OnConfigurationUpdated(object _, LanguageServerSettings settings)
         {
-            if (settings.ScriptAnalysis.Enable ?? true)
+            if (settings.ScriptAnalysis.Enable)
             {
                 InitializeAnalysisEngineToCurrentSettings();
             }

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/DisconnectHandler.cs

@@ -67,8 +67,7 @@ await _executionService.ExecutePSCommandAsync(
                                 new PSCommand().AddCommand("Exit-PSHostProcess"),
                                 CancellationToken.None).ConfigureAwait(false);
 
-                            if (_debugStateService.IsRemoteAttach &&
-                                _runspaceContext.CurrentRunspace.RunspaceOrigin == RunspaceOrigin.EnteredProcess)
+                            if (_debugStateService.IsRemoteAttach)
                             {
                                 await _executionService.ExecutePSCommandAsync(
                                     new PSCommand().AddCommand("Exit-PSSession"),

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/LaunchAndAttachHandler.cs

@@ -420,8 +420,7 @@ private async Task OnExecutionCompletedAsync(Task executeTask)
                     {
                         await _executionService.ExecutePSCommandAsync(new PSCommand().AddCommand("Exit-PSHostProcess"), CancellationToken.None).ConfigureAwait(false);
 
-                        if (_debugStateService.IsRemoteAttach &&
-                            _runspaceContext.CurrentRunspace.RunspaceOrigin != RunspaceOrigin.Local)
+                        if (_debugStateService.IsRemoteAttach)
                         {
                             await _executionService.ExecutePSCommandAsync(new PSCommand().AddCommand("Exit-PSSession"), CancellationToken.None).ConfigureAwait(false);
                         }

src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs

@@ -64,10 +64,8 @@ public override async Task<Unit> Handle(DidChangeConfigurationParams request, Ca
             SendFeatureChangesTelemetry(incomingSettings);
 
             bool profileLoadingPreviouslyEnabled = _configurationService.CurrentSettings.EnableProfileLoading;
-            bool oldScriptAnalysisEnabled =
-                _configurationService.CurrentSettings.ScriptAnalysis.Enable ?? false;
-            string oldScriptAnalysisSettingsPath =
-                _configurationService.CurrentSettings.ScriptAnalysis?.SettingsPath;
+            bool oldScriptAnalysisEnabled = _configurationService.CurrentSettings.ScriptAnalysis.Enable;
+            string oldScriptAnalysisSettingsPath = _configurationService.CurrentSettings.ScriptAnalysis?.SettingsPath;
 
             _configurationService.CurrentSettings.Update(
                 incomingSettings.Powershell,
@@ -186,10 +184,10 @@ private void SendFeatureChangesTelemetry(LanguageServerSettingsWrapper incomingS
 
             Dictionary<string, bool> configChanges = new();
             // Send telemetry if the user opted-out of ScriptAnalysis
-            if (incomingSettings.Powershell.ScriptAnalysis.Enable == false &&
+            if (!incomingSettings.Powershell.ScriptAnalysis.Enable &&
                 _configurationService.CurrentSettings.ScriptAnalysis.Enable != incomingSettings.Powershell.ScriptAnalysis.Enable)
             {
-                configChanges["ScriptAnalysis"] = incomingSettings.Powershell.ScriptAnalysis.Enable ?? false;
+                configChanges["ScriptAnalysis"] = incomingSettings.Powershell.ScriptAnalysis.Enable;
             }
 
             // Send telemetry if the user opted-out of CodeFolding

src/PowerShellEditorServices/Services/Workspace/LanguageServerSettings.cs

@@ -54,7 +54,7 @@ public void Update(
     internal class ScriptAnalysisSettings
     {
         private readonly object updateLock = new();
-        public bool? Enable { get; set; }
+        public bool Enable { get; set; }
         public string SettingsPath { get; set; }
         public ScriptAnalysisSettings() => Enable = true;