Update Appx manifest with new cap and fix statically linking to vcruntime #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR includes code cleanup and configuration improvements across build scripts, CI/CD pipelines, and project templates.
- Simplifies Azure CLI authentication logic by removing redundant command existence checks
- Fixes URL formatting issue in Azure DevOps pipeline
- Corrects spelling error in issue template
- Updates Cargo configuration for Windows MSVC targets with explicit CRT linking flags
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build.ps1 | Removes redundant nested Azure CLI command check, streamlining authentication flow |
| .pipelines/DSC-Official.yml | Fixes malformed Azure DevOps organization URL (removes double slash) |
| .github/ISSUE_TEMPLATE/Feature_Request.yml | Corrects duplicate word in placeholder text |
| .cargo/config.toml | Expands rustflags configuration with explicit Windows CRT library linking arguments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteveL-MSFT
changed the title
DHowett
suggested changes
Nov 7, 2025
| } | ||
|
|
||
| $env:RUSTC_LOG=$null | ||
| $env:RUSTFLAGS='-Dwarnings' |
There was a problem hiding this comment.
Whoops, you still have one of these in build.helpers.psm1 as well. Line 753-754
There was a problem hiding this comment.
BUILD: Performing setup steps::Configuring Rust environment
VERBOSE: Caching current rust environment variables...
VERBOSE: No Rust environment variables defined
VERBOSE: Setting RUSTFLAGS to '-Dwarnings'
DHowett
approved these changes
Nov 8, 2025
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
It's perfect. Not a DLL dependency out of place.
adityapatwardhan
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes some issues:
azContext
Fix #1243
Fix #1244