-
Notifications
You must be signed in to change notification settings - Fork 46
implement __repr__ for PowerGridModel
#1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Clemens Korner <clemens.korner@gmail.com>
mgovers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting to see how this shows up in the VSCode editor (see image)
- By default, only
PowerGridModel (#### components)shows - When hovering over it, the rest also shows.
I think that this is reasonable. The python docs also doesn't explicitly forbid that, so I think it's good as-is.
Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kornerc, Another great PR 👍 Thanks again for your contribution!
You're welcome! In my previous PR you've asked me about feedback for the contribution process. Unfortunately, I cannot join the meeting today. |
Sounds good! I guess the next community meeting would be perfect for this. Looking forward to it. |
Fixes issue: #1198
Example:
Prints: