Skip to content

Conversation

@UttuG
Copy link
Collaborator

@UttuG UttuG commented Nov 8, 2025

new folder for data collection

implemented:
task verifier (for both grasping and final traj)
motion planning error fallback and recalculation of grasp/traj when needed (see open issue)

to do:
implement logic for multiple env

@UttuG
Copy link
Collaborator Author

UttuG commented Nov 10, 2025

any issue with this PR @PointsCoder ?

Copy link
Owner

@PointsCoder PointsCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you copy eveything inside the data collection folder. Can you keep a minimal script in the data collection without duplicating a lot of code? Thanks

@UttuG
Copy link
Collaborator Author

UttuG commented Nov 11, 2025

So it is just that the sim_manip file is importing a lot of code from these files. In reality only sim_base is being changed besides sim_manip but the import structure is a little iffy then.

I would need to turn it into a python package and then the running structure for this file would differ from the rest of the repo (would need to use -m). Or i need to use system paths and set it which would make it susceptible to any other future updates.

What do you suggest?

@UttuG
Copy link
Collaborator Author

UttuG commented Nov 15, 2025

closing PR as #42 addresses this and other features too

@UttuG UttuG closed this Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants