Gong "New Call" trigger update pagination #18979
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds a deploy-time hook limiting initial Gong "New Call" retrieval to 25 items, narrows the default lookback from three months to one day, and bumps the Gong package version and platform dependency. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeployHook as Deploy Hook
participant RunFlow as Regular Run
participant GongAPI as Gong API
rect rgba(220,240,255,0.6)
Note over User,GongAPI: Initial deployment flow (limited)
User->>DeployHook: deploy source
DeployHook->>GongAPI: fetch resources (paginated)
GongAPI-->>DeployHook: resources list
DeployHook->>DeployHook: processResources(resources, max=25)
DeployHook->>User: emit up to 25 events
end
rect rgba(235,255,230,0.6)
Note over User,GongAPI: Subsequent scheduled runs (timestamp-filtered)
User->>RunFlow: scheduled trigger
RunFlow->>GongAPI: fetch resources filtered by fromDateTime (one day lookback)
GongAPI-->>RunFlow: recent resources
RunFlow->>RunFlow: processResources(resources) %% no max
RunFlow->>User: emit new events
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
components/gong/package.json(2 hunks)components/gong/sources/common/polling.mjs(2 hunks)components/gong/sources/new-call/new-call.mjs(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-01-23T03:55:15.166Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Applied to files:
components/gong/sources/new-call/new-call.mjs
🧬 Code graph analysis (1)
components/gong/sources/common/polling.mjs (1)
components/zep/actions/get-threads/get-threads.mjs (1)
max(39-39)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (5)
components/gong/package.json (1)
3-3: LGTM: Version and dependency updates are appropriate.The version bump and platform dependency update align with the feature changes in this PR.
Also applies to: 16-16
components/gong/sources/common/polling.mjs (1)
42-58: LGTM: processResources correctly limits emission while maintaining timestamp tracking.The logic properly reverses resources to descending order, slices to the newest N events when max is provided, and updates lastCreatedAt to the newest emitted resource. This ensures subsequent runs fetch only newer events.
components/gong/sources/new-call/new-call.mjs (3)
7-7: LGTM: Description is clear and specific.The updated description explicitly states the trigger behavior and includes relevant API documentation.
9-9: LGTM: Version bump is appropriate.Patch version increment is correct for this bug fix.
20-24: Key fix: Lookback window reduced from 3 months to 1 day.This change directly addresses the indefinite pagination issue reported in #18965. By reducing the default lookback window from 3 months to 1 day, the initial deployment will fetch far fewer historical calls, preventing the emission of 1000+ events. Combined with the deploy hook's 25-event emission limit, this ensures a controlled initial deployment.
The 1-day window strikes a good balance between avoiding excessive historical data and capturing recent events.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
components/babelfy/babelfy.app.mjs(1 hunks)components/bitrated/bitrated.app.mjs(1 hunks)components/crypto_apis_by_alternative/crypto_apis_by_alternative.app.mjs(1 hunks)components/embedapi/embedapi.app.mjs(1 hunks)components/financial_modeling_prep/financial_modeling_prep.app.mjs(1 hunks)components/ideta/ideta.app.mjs(1 hunks)components/intelitruth/intelitruth.app.mjs(1 hunks)components/jooble/jooble.app.mjs(1 hunks)components/live_score_api/live_score_api.app.mjs(1 hunks)components/loginradius/loginradius.app.mjs(1 hunks)components/mallabe/mallabe.app.mjs(1 hunks)components/marcom_robot/marcom_robot.app.mjs(1 hunks)components/microsoft_azure_monitor/microsoft_azure_monitor.app.mjs(1 hunks)components/mymemory/mymemory.app.mjs(1 hunks)components/stock_news_api/stock_news_api.app.mjs(1 hunks)components/stocknewsapi/stocknewsapi.app.mjs(1 hunks)components/webspellchecker/webspellchecker.app.mjs(1 hunks)components/yext_sandbox/yext_sandbox.app.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (17)
components/mymemory/mymemory.app.mjs (1)
11-11: Formatting standardization approved.The addition of a trailing newline at end-of-file aligns with standard formatting conventions and is consistent with the broader formatting updates noted in this PR. No functional impact.
components/webspellchecker/webspellchecker.app.mjs (1)
11-11: Verify file relevance to PR objectives.This file (webspellchecker component) appears unrelated to the PR's stated objectives of fixing Gong "New Call" trigger pagination indefinite loops. The only change is adding an EOF newline—a formatting-only update.
Confirm whether this file should be included in this PR or if it was accidentally included in a broader formatting pass across components.
components/marcom_robot/marcom_robot.app.mjs (1)
11-11: Formatting-only change unrelated to PR objectives.The added trailing newline is a formatting change that's not related to fixing the Gong "New Call" trigger pagination issue. To keep the PR focused and the commit history clean, consider removing this formatting change and excluding it from the current PR.
components/ideta/ideta.app.mjs (1)
11-11: File appears unrelated to PR objectives; clarify scope.This file contains only a cosmetic trailing-newline addition. However, the PR objectives specifically address Gong "New Call" trigger pagination fixes—including deploy-time hooks, initial fetch limits to 25 items, and default lookback adjustments. This IDeta app component does not implement those fixes.
Please verify that all relevant Gong trigger files are included in the review. The actual changes for resolving issue #18965 should be in the Gong component files (e.g., under
components/gong/), not in unrelated app files.components/intelitruth/intelitruth.app.mjs (1)
1-11: Mismatch between PR objectives and provided file.The PR objectives state that this PR resolves issue #18965 by adding a deploy-time hook to limit the Gong "New Call" trigger to 25 items on initial deployment and implementing proper timestamp-based filtering. However, the provided file is an unrelated
intelitruthcomponent with only a trailing newline formatting change, which does not address the stated objectives.Please verify that the correct files were provided for review. The actual Gong trigger component (likely at
components/gong/triggers/new-call.mjsor similar) should contain the pagination-limiting logic and deploy-time hook mentioned in the PR summary. Could you provide the Gong trigger file(s) that implement the fix?components/yext_sandbox/yext_sandbox.app.mjs (1)
11-11: Formatting change looks fine.Trailing newline addition is harmless.
components/loginradius/loginradius.app.mjs (1)
11-11: LGTM! Formatting-only change.This trailing newline addition is a benign formatting update with no functional impact. It's part of a broader repository-wide formatting cleanup.
components/mallabe/mallabe.app.mjs (1)
11-11: Trailing newline looks good.Formatting-only change; nothing else to address.
components/jooble/jooble.app.mjs (1)
11-11: Trailing newline looks good.Formatting-only change; nothing else to address.
components/bitrated/bitrated.app.mjs (1)
11-11: Trailing newline looks good.Formatting-only change; nothing else to address.
components/stocknewsapi/stocknewsapi.app.mjs (1)
11-11: Trailing newline looks good.Formatting-only change; nothing else to address.
components/live_score_api/live_score_api.app.mjs (1)
11-11: Trailing newline looks good.Formatting-only change; nothing else to address.
components/crypto_apis_by_alternative/crypto_apis_by_alternative.app.mjs (1)
11-11: Formatting-only change; no functional impact.This file receives only a trailing newline addition as part of a repo-wide formatting pass. No logic, behavior, or public API changes.
components/microsoft_azure_monitor/microsoft_azure_monitor.app.mjs (1)
11-11: Formatting-only change; no functional impact.Trailing newline addition only. No logic, behavior, or public API changes.
components/embedapi/embedapi.app.mjs (1)
11-11: Formatting-only change; no functional impact.Trailing newline addition only. No logic, behavior, or public API changes.
components/babelfy/babelfy.app.mjs (1)
11-11: Formatting-only change; no functional impact.Trailing newline addition only. No logic, behavior, or public API changes.
components/stock_news_api/stock_news_api.app.mjs (1)
11-11: Formatting-only change; no functional impact.Trailing newline addition only. No logic, behavior, or public API changes.
Resolves #18965
Summary by CodeRabbit
Chores
Changes