Skip to content

Update PR linting instructions #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update PR linting instructions #2213

wants to merge 3 commits into from
+32 −6

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Dec 1, 2025 •
edited
Loading

Description

Removes the checkbox for linting. Also prints a link to the linting docs on CI failure.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • This PR has been linted.
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner December 1, 2025 15:33
mcm001
mcm001 reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this being enabled on every failure, not just on pull requests. Also would be great to see an example of this in a job log

@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Dec 1, 2025
@samfreund samfreund force-pushed the lint-reminder branch 2 times, most recently from 1c02d94 to 9c3f998 Compare December 1, 2025 23:32
@github-actions github-actions bot removed the frontend Having to do with PhotonClient and its related items label Dec 3, 2025
@samfreund samfreund force-pushed the lint-reminder branch 5 times, most recently from 826e0f8 to afe2c79 Compare December 4, 2025 17:42
Gold856
Gold856 requested changes Dec 4, 2025
View reviewed changes
Copy link
Collaborator

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a set +e to let the script keep going after a non-zero exit code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcm001 mcm001 mcm001 left review comments

@Gold856 Gold856 Gold856 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samfreund @mcm001 @Gold856