-
-
Notifications
You must be signed in to change notification settings - Fork 124
[Highly Customized] Distribution click action mode #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CrimRecya
wants to merge
45
commits into
Phobos-developers:develop
Choose a base branch
from
CrimRecya:develop-Distribution
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+745
−2
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
325989f
Core
CrimRecya 4875c49
Merge branch 'develop' into develop-Distribution
CrimRecya 6edc48e
Update Whats-New.md
CrimRecya 73a6c0b
Draw at mouse
CrimRecya 97c070d
Show range ring
CrimRecya e242669
Fix a typo
CrimRecya ab9c046
Fix target cloaked units
CrimRecya 97f0e11
Merge branch 'develop' into develop-Distribution
CrimRecya 32c90bd
")"
DeathFishAtEase 82ea77c
Add a hold down key to enable
CrimRecya 957b2ef
Merge branch 'develop' into develop-Distribution
CrimRecya d279944
Doc
CrimRecya 4444222
Fix target shrouded units
CrimRecya 40051d9
Fix target disguised units
CrimRecya 2e38594
Fix target outside units
CrimRecya 55723f3
Global toggle
CrimRecya dab3385
Merge branch 'develop' into develop-Distribution
CrimRecya 1c47634
Message, sound and scroll action
CrimRecya 90556bd
Merge remote-tracking branch 'upstream/develop' into develop-Distribu…
CrimRecya f4ae01b
Merge remote-tracking branch 'upstream/develop' into develop-Distribu…
CrimRecya 6ce7407
Fix merge
CrimRecya 685d456
Low distance first
CrimRecya 1bb257d
...
CrimRecya ce16654
Merge remote-tracking branch 'upstream/develop' into develop-Distribu…
Coronia 96c6a06
Merge branch 'develop' into develop-Distribution
Coronia 25574cc
Code style
CrimRecya cd1b12f
Merge remote-tracking branch 'upstream/develop' into develop-Distribu…
Coronia 3191dab
remove unnecessary Grinder process
Coronia 55b7208
Merge branch 'develop' into develop-Distribution
Coronia 4d1c883
Merge remote-tracking branch 'upstream/develop' into develop-Distribu…
CrimRecya b55908a
Refactor
CrimRecya 6525feb
Remove useless
CrimRecya 09bae51
Fix default value
CrimRecya aa509d0
Separate functions
CrimRecya e0bbe02
Fix include
CrimRecya 573d8f8
Fit with FakeOf
CrimRecya fdd82ac
Merge branch 'develop' into develop-Distribution
CrimRecya 4ab9876
TODO
CrimRecya 2892caf
Merge branch 'develop' into develop-Distribution
CrimRecya e49a75f
Update YRpp
CrimRecya eb552f1
Button on bottom
CrimRecya 27ca512
update doc
Coronia 88c6cbe
Merge branch 'develop' into develop-Distribution
Coronia 9dcbd2c
revert YRpp
Coronia 744bf42
Merge branch 'develop' into develop-Distribution
Coronia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be refactored, and it is important as it's a framework code and it is going to be used for other buttons as well.
Per @tomsons26 who is well into the engine(s), the bottom bar is called
Advanced Command Bar. I propose to transform those static array fields into fields ofAdvancedCommandBarButtonClassand use a similar approach with registering as withCommandClass.Maybe it would also be beneficial to place commands and command buttons separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Courtesy of @tomsons26