Passive acquire mode #1849

TaranDahl · 2025-09-10T04:19:17Z

Passive acquire mode

Now you can order the units to enter "Ceasefire Mode" or "Aggressive Mode", just like in RA3.
- In ceasefire mode, units will only attack the targets specified by the player.
- In aggressive mode, units will automatically attack all enemies, including buildings without weapons.
- In normal mode, units will auto-target like usual.
You can use two hotkeys to switch between these two modes if [General] -> EnablePassiveAcquireMode is set to true. When you press one of these hotkeys:
- If all selected units are in that mode, they will switch to the normal mode. Otherwise, they will enter that mode. Units that cannot switch modes are not counted.
- If any unit successfully switches its mode, a sound effect will be emitted. This sound can be customized through [TechnoType] -> Voice(Enter/Exit)(Aggressive/Ceasefire)Mode.
You can use [TechnoType] -> PassiveAcquireMode.Togglable to specify whether the unit can toggle its mode.
You can use [TechnoType] -> PassiveAcquireMode to specify the unit's initial mode.

In rulesmd.ini:

[General]
EnablePassiveAcquireMode=false        ; boolean

[SOMETECHNO]                          ; TechnoType
PassiveAcquireMode=Normal             ; passive acquire mode, Normal / Aggressive / Ceasefire
PassiveAcquireMode.Togglable=true     ; boolean
VoiceEnterAggressiveMode=             ; Sound entry, default to VoiceAttack or VoiceMove
VoiceExitAggressiveMode=              ; Sound entry, default to VoiceMove or VoiceSelect
VoiceEnterCeasefireMode=              ; Sound entry, default to VoiceSelect or VoiceMove
VoiceExitCeasefireMode=               ; Sound entry, default to VoiceAttack or VoiceMove

`[ ]` Ceasefire Mode

Order the selected units to enter or exit the ceasefire mode. See this for details.
For localization add TXT_CEASEFIRE_MODE, TXT_CEASEFIRE_MODE_DESC, MSG:CEASEFIRE_MODE_ON and MSG:CEASEFIRE_MODE_OFF into your .csf file.

`[ ]` Aggressive Mode

Order the selected units to enter or exit the aggressive mode. See this for details.
For localization add TXT_AGGRESSIVE_MODE, TXT_AGGRESSIVE_MODE_DESC, MSG:AGGRESSIVE_MODE_ON and MSG:AGGRESSIVE_MODE_OFF into your .csf file.

github-actions · 2025-09-10T04:25:36Z

Nightly build for this pull request:

compiled-dll-7655eba8f2cfb55d1dc0c0369013fea334d13231.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Metadorius · 2025-09-10T07:22:43Z

Previously when discussing stances we figured there should be a button/indicator at bottom bar. Have this went anywhere? If I recall correctly, someone even had the code to add custom buttons there.

TaranDahl · 2025-09-10T07:56:18Z

Previously when discussing stances we figured there should be a button/indicator at bottom bar. Have this went anywhere? If I recall correctly, someone even had the code to add custom buttons there.

Hmmmm ... where is that code then🤔

FS-21 · 2025-09-10T09:20:22Z

Aggressive stance if I'm not wrong :-/

TaranDahl · 2025-09-10T09:27:02Z

Aggressive stance if I'm not wrong :-/

#1464 did not touch the bottom bar.

Coronia · 2025-09-10T09:29:14Z

Could there be visual indicator on techno to tell which of them is in aggressive/passive stance if it’s toggleable?

TaranDahl · 2025-09-10T09:39:04Z

Maybe it could be drawn next to the unit like the insignia.
But I don't think this is a good idea. We already have too many things to draw next to the unit.
I'm asking Crim to open a pr for his bottom bar.

Metadorius · 2025-09-12T11:36:16Z

Maybe it could be drawn next to the unit like the insignia. But I don't think this is a good idea. We already have too many things to draw next to the unit. I'm asking Crim to open a pr for his bottom bar.

I think @Otamaa had the code for custom vanilla bottom bar buttons?

CrimRecya · 2025-09-13T13:14:12Z

About the buttons on bottom:
https://github.com/CrimRecya/Phobos-Mix/blob/Mix-ECpack/src/Commands/Commands.cpp#L180C1-L180C69
https://github.com/CrimRecya/Phobos-Mix/blob/Mix-ECpack/src/Commands/Commands.h#L17

Otamaa · 2025-09-18T09:49:52Z

Maybe it could be drawn next to the unit like the insignia. But I don't think this is a good idea. We already have too many things to draw next to the unit. I'm asking Crim to open a pr for his bottom bar.

I think @Otamaa had the code for custom vanilla bottom bar buttons?

my code is more big than Crim one , i do play around with these for a bit just for fun :
https://github.com/Otamaa/Phobos-Minimal/blob/f2ac3f68b7561d3b91b1d59d13ac9f6a601cb573/src/Misc/Hook.CommandButtons.cpp

TaranDahl · 2025-10-30T09:00:15Z

Previously when discussing stances we figured there should be a button/indicator at bottom bar. Have this went anywhere? If I recall correctly, someone even had the code to add custom buttons there.

@Metadorius The existing code has exceeded 500 lines. I think it's better to complete this PR before initiating a new one to finish these tasks, to avoid overwhelming the reviewer with too much code. What do you think?

Metadorius · 2025-10-30T09:22:21Z

@Metadorius The existing code has exceeded 500 lines. I think it's better to complete this PR before initiating a new one to finish these tasks, to avoid overwhelming the reviewer with too much code. What do you think?

@TaranDahl I propose to take CrimRecya's implementation of the bottom bar buttons from #1453 separately as a new PR without any extra logics (maybe could do a new button for triggering Select Next Idle Harvester command; however, I am not sure if the buttons have to be always tied to CommandClass, this is up for discussion), reviewing/refactoring it so it fits our standards, merging, and then rebasing this PR so it can use it.

oh and don't merge latest develop commit, we're deciding how to proceed on it

Metadorius · 2025-10-30T22:42:28Z

resolved the situation with develop, feel free to merge it

CrimRecya

There are some minor issues, but overall it looks good. I think the bottom bar part can be added after merging, of course, it depends on what you think.

CrimRecya · 2025-11-08T10:30:08Z

src/Commands/Commands.cpp

+#include <CCINIClass.h>
+#include <InputManagerClass.h>
+#include <MouseClass.h>
+#include <WWMouseClass.h>
+
+#include <Utilities/Macro.h>


I think you don't need these for the time being.

CrimRecya · 2025-11-08T10:34:10Z

src/Commands/PassiveAcquireMode.cpp

+				isAllSelectedUnitAggressiveMode = false;
+				TechnoVectorNonAggressive.push_back(pTechno);
+			}
+			return;


This line of return is a bit redundant.

CrimRecya · 2025-11-08T10:34:32Z

src/Commands/PassiveAcquireMode.cpp

+				isAllSelectedUnitCeasefireMode = false;
+				TechnoVectorNonCeasefire.push_back(pTechno);
+			}
+			return;


Same as above.

CrimRecya · 2025-11-08T11:16:26Z

src/Ext/Rules/Body.cpp

@@ -1,4 +1,4 @@
-#include "Body.h"
+#include "Body.h"


You may have accidentally modified the encoding format of the file.

CrimRecya · 2025-11-08T11:17:04Z

src/Ext/Rules/Body.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once


Same as above.

CrimRecya · 2025-11-08T11:18:35Z

src/Ext/TechnoType/Body.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once


Same as above.

CrimRecya · 2025-11-08T11:28:35Z

src/Ext/Techno/Hooks.TargetEvaluation.cpp

+DEFINE_HOOK(0x6F8E1F, TechnoClass_SelectAutoTarget_CeasefireMode, 0x6)
+{
+	GET(TechnoTypeClass*, pType, EAX);
+	GET(TechnoClass*, pThis, ESI);
+	R->CL(pType->NoAutoFire || (TechnoExt::ExtMap.Find(pThis)->GetPassiveAcquireMode()) == PassiveAcquireMode::Ceasefire);
+	return R->Origin() + 0x6;
+}


I think this hook will make AI to ignore the ceasefire mode?

CrimRecya · 2025-11-08T11:37:54Z

src/Ext/Techno/Body.h

+#pragma once
 #include <InfantryClass.h>
 #include <AnimClass.h>

+#include <Ext/TechnoType/Body.h>
+#include <Ext/BuildingType/Body.h>


If possible, prioritize including these dependencies in separate files instead of including them in header files.

CrimRecya · 2025-11-08T11:41:52Z

src/Ext/Techno/Body.cpp

+	auto previousMode = this->PassiveAquireMode;
+	this->PassiveAquireMode = newMode;
+
+	if (newMode == previousMode)
+		return;


Suggested change

auto previousMode = this->PassiveAquireMode;

this->PassiveAquireMode = newMode;

if (newMode == previousMode)

return;

const auto previousMode = this->PassiveAquireMode;

if (newMode == previousMode)

return;

this->PassiveAquireMode = newMode;

CrimRecya · 2025-11-08T11:48:05Z

src/Ext/Techno/Body.cpp

+
+	const auto pThis = this->OwnerObject();
+	const auto pTechnoType = this->TypeExtData->OwnerObject();
+	int voiceIndex;


Sorry, it's just a suggestion. I just don't like having an uninitialized variable. You can try encapsulating the following code into a static inline or lambda function called process... and returning a voice index.

TaranDahl · 2025-11-09T13:05:48Z

@TaranDahl I propose to take CrimRecya's implementation of the bottom bar buttons from #1453 separately as a new PR without any extra logics (maybe could do a new button for triggering Select Next Idle Harvester command; however, I am not sure if the buttons have to be always tied to CommandClass, this is up for discussion), reviewing/refactoring it so it fits our standards, merging, and then rebasing this PR so it can use it.

@CrimRecya How about this

TaranDahl added 7 commits September 10, 2025 00:35

impl

7b30373

Update Hooks.TargetEvaluation.cpp

e279223

AggressiveMode

fc899ac

Update Commands.cpp

d304b1c

Update Phobos.vcxproj

ba3fb49

update

96ccf74

docs and update

8a7a38b

TaranDahl added ❓New feature ⚙️T2 T2 maintainer review is sufficient labels Sep 10, 2025

Update Hooks.cpp

715e194

CrimRecya approved these changes Nov 8, 2025

View reviewed changes

CrimRecya added Fix and merge this Needs testing labels Nov 8, 2025

Uh oh!

Passive acquire mode #1849

Are you sure you want to change the base?

Passive acquire mode #1849

Conversation

TaranDahl commented Sep 10, 2025