Fix browsing nodes #891
Merged
Fix browsing nodes #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeuchler
reviewed
Dec 2, 2025
src/Tests/Moryx.Drivers.OpcUa.Tests/HandlingCyclicNodesTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 2, 2025
Merged
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
src/Tests/Moryx.Drivers.OpcUa.Tests/HandlingCyclicNodesTests.cs
Outdated
Show resolved
Hide resolved
seveneleven
force-pushed
the
fix-browsing-nodes
branch
2 times, most recently
from
22ecf20 to
4fd875c
Compare
dbeuchler
reviewed
Dec 2, 2025
Member
|
@seveneleven Are all OpcUa-tests fixed with this PR? Maybe merge future into this branch. We weit for that in #830. |
seveneleven
force-pushed
the
fix-browsing-nodes
branch
from
4fd875c to
2e4864a
Compare
* It has a URI if URI (and namespace index) is set * It has a namespace index, if no URI is set * Namespace index is removed if `ns=0` (as it is the default)
It's common, that OPC UA nodes appear in multiple positions of the tree. But after they appeared once, they've been skipped for all other occurrences. This is fixed now: Nodes will be listed, if they occur in different branches of the tree. They will be ignored though, if they appear more than once on the same branch. Also, if already found, they won't be updated by following occurrences, assuming that nodes with the same ID will be the same entity.
Used `CultureInfo.InvariantCulture` to parse culture independent.
* Unused variables/parameters * Unnecessary usings * ...
seveneleven
force-pushed
the
fix-browsing-nodes
branch
2 times, most recently
from
7eae03a to
225535f
Compare
Contributor
Author
Yes, they are |
Member
nice!! |
dbeuchler
reviewed
Dec 3, 2025
dbeuchler
reviewed
Dec 3, 2025
dbeuchler
reviewed
Dec 3, 2025
dbeuchler
reviewed
Dec 3, 2025
seveneleven
force-pushed
the
fix-browsing-nodes
branch
from
225535f to
e0c9536
Compare
seveneleven
force-pushed
the
fix-browsing-nodes
branch
from
e0c9536 to
a216e48
Compare
dbeuchler
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common, that OPC UA nodes appear in multiple positions of the tree. But
after they appeared once, they've been skipped for all other occurrences.
This is fixed now: Nodes will be listed, if they occur in different branches of
the tree. They will be ignored though, if they appear more than once on the
same branch. Also, if already found, they won't be updated by following
occurrences, assuming that nodes with the same ID will be the same entity.