Feat: Add support custom_dir_path #88

malvinpratama · 2025-08-26T16:21:10Z

I am not good for documentation. But this PR is for support melos/microfrontend. So, we can set where the output file will generated. For now only support on android & ios

- Add support for custom_dir_path on melos

OutdatedGuy · 2025-08-29T10:14:58Z

Hi @malvinpratama thanks for the PR, I see you have added an additional key to specify custom directory path, but it seems to be not implemented for every function (in android and ios) i.e. Implemented for _setAndroidAppName and _setAndroidPackageName but not for _createNewMainActivity in android.

Also I was not able to run this implementation successfully on my side. Can you add some configuration details that I need to know?

P.S. Marking this PR as draft.

malvinpratama · 2025-08-31T01:58:54Z

Hi @malvinpratama thanks for the PR, I see you have added an additional key to specify custom directory path, but it seems to be not implemented for every function (in android and ios) i.e. Implemented for _setAndroidAppName and _setAndroidPackageName but not for _createNewMainActivity in android.

Also I was not able to run this implementation successfully on my side. Can you add some configuration details that I need to know?

P.S. Marking this PR as draft.

@OutdatedGuy Sorry I forgot to commit that. Please check again

OutdatedGuy · 2025-08-31T10:50:50Z

Hi @malvinpratama, the errors are now gone, but I still need help setting up melos. Can you help me with that for testing?

Update constants.dart

…movement

Copilot

Pull Request Overview

This PR adds support for custom directory paths to enable melos/microfrontend architecture setups. The feature allows users to specify where output files should be generated instead of using the default android/app and ios directories.

Key changes:

Added custom_dir_path and host configuration keys
Updated Android and iOS platform implementations to support custom directory paths
Changed Kotlin MainActivity template from FlutterActivity to FlutterFragmentActivity

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
lib/constants.dart	Added new configuration keys (`_customDirPath`, `_host`) and updated Kotlin MainActivity template to use `FlutterFragmentActivity`
lib/platforms/android.dart	Added custom directory path support to all Android file operations and introduced `host` parameter for AndroidManifest.xml modification
lib/platforms/ios.dart	Added custom directory path support to iOS display name, bundle name, and package name configuration functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-12T03:14:20Z

lib/constants.dart

+import io.flutter.embedding.android.FlutterFragmentActivity

-class MainActivity : FlutterActivity()
+class MainActivity : FlutterFragmentActivity()


The Kotlin template was changed to use FlutterFragmentActivity instead of FlutterActivity, but the Java template (lines 141-143) still uses FlutterActivity. This creates an inconsistency between the two templates. Both should use the same base class, or the difference should be intentional and documented.

If this change is intentional and related to supporting microfrontends, consider:

Updating the Java template to also use FlutterFragmentActivity

Or explaining why the templates differ in their respective use cases

Copilot · 2025-11-12T03:14:21Z

lib/platforms/android.dart

+    final androidMainManifestFilePath =
+        (customDirPath is String && customDirPath.isNotEmpty)
+            ? _androidMainManifestFilePath.replaceAll(
+                _androidAppDirPath, customDirPath)
+            : _androidMainManifestFilePath;


The path replacement logic (customDirPath is String && customDirPath.isNotEmpty) ? path.replaceAll(...) : path is duplicated multiple times throughout the Android and iOS implementations. Consider extracting this into a helper function to improve maintainability:

String _getCustomPath(String defaultPath, String? customDirPath, String defaultDir) { return (customDirPath is String && customDirPath.isNotEmpty) ? defaultPath.replaceAll(defaultDir, customDirPath) : defaultPath; }

This would simplify all the path calculations and make the code more maintainable.

Copilot · 2025-11-12T03:14:21Z

lib/platforms/ios.dart

+    final iosInfoPlistFilePath = (customDirPath is String && customDirPath.isNotEmpty)
+        ? _iosInfoPlistFilePath.replaceFirst(_iosDirPath, customDirPath)
+        : _iosInfoPlistFilePath;


Inconsistency in path replacement methods: iOS uses replaceFirst while Android uses replaceAll for the same purpose (custom directory path replacement). Since directory paths like _iosDirPath ('ios') and _androidAppDirPath ('android/app') should only appear once at the beginning of the path, both should use the same method for consistency.

Consider using replaceFirst consistently across both platforms, as it's more precise and avoids potential issues if the directory name appears elsewhere in the path.

Copilot · 2025-11-12T03:14:21Z

lib/platforms/android.dart

    if (androidConfig != null) _logger.w(_majorTaskDoneLine);
  }
 }



The new customDirPath and host parameters lack documentation. Consider adding documentation comments to explain:

What customDirPath is used for (custom directory path for melos/microfrontend support)

What host is used for (appears to set the android:host attribute in AndroidManifest.xml)

Expected format/values for each parameter

Example:

/// Sets the Android app name in the AndroidManifest.xml file. /// /// [appName] - The display name for the Android application /// [customDirPath] - Optional custom directory path for the android/app folder, /// used in melos/microfrontend setups /// [host] - Optional host value to set in the AndroidManifest.xml void _setAndroidAppName(dynamic appName, String? customDirPath, dynamic host) {

Suggested change

/// Sets the Android app name and optionally the android:host attribute in the AndroidManifest.xml file.

///

/// [appName] - The display name for the Android application. Must be a non-empty String.

/// [customDirPath] - Optional custom directory path for the android/app folder, used in melos/microfrontend setups.

/// If provided and non-empty, replaces the default android/app directory path when locating the manifest file.

/// [host] - Optional host value to set in the AndroidManifest.xml. If provided and non-empty, sets the android:host attribute.

Copilot · 2025-11-12T03:14:22Z

lib/platforms/ios.dart

 }

-void _setIOSDisplayName(dynamic appName) {
+void _setIOSDisplayName(dynamic appName, {String? customDirPath}) {


The new customDirPath parameter lacks documentation. Consider adding documentation comments to explain what it's used for and expected format:

/// Sets the iOS display name in the Info.plist file. /// /// [appName] - The display name for the iOS application /// [customDirPath] - Optional custom directory path for the ios folder, /// used in melos/microfrontend setups void _setIOSDisplayName(dynamic appName, {String? customDirPath}) {

Feat:

1d13985

- Add support for custom_dir_path on melos

malvinpratama mentioned this pull request Aug 26, 2025

Specifying application path in config yaml #2

Open

OutdatedGuy marked this pull request as draft August 29, 2025 10:15

malvinpratama added 2 commits August 31, 2025 08:53

feat(android): enhance configuration handling with custom directory path

c1ce4b9

feat(android): remove logging of custom directory path in configuration

a0e6263

malvinpratamaputra and others added 7 commits September 16, 2025 16:08

Update constants.dart

3477c32

Merge pull request #1 from malvinpratamaputra/patch-1

550fe1f

Update constants.dart

Merge branch 'OutdatedGuy:main' into support-melos

35602d4

feat(android): add host parameter to Android app name configuration

a6273f7

feat(android): update Android host in AndroidManifest.xml configuration

bf6d3b8

feat(android): update directory path handling in _createNewMainActivity

0e5d755

feat(android): enhance logging for MainActivity creation and package …

b577152

…movement

OutdatedGuy requested a review from Copilot November 12, 2025 03:09

Copilot started reviewing on behalf of OutdatedGuy November 12, 2025 03:10 View session

Copilot finished reviewing on behalf of OutdatedGuy November 12, 2025 03:13

Copilot AI reviewed Nov 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feat: Add support custom_dir_path #88

Feat: Add support custom_dir_path #88

Uh oh!

malvinpratama commented Aug 26, 2025

Uh oh!

OutdatedGuy commented Aug 29, 2025

Uh oh!

malvinpratama commented Aug 31, 2025

Uh oh!

OutdatedGuy commented Aug 31, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+/// Sets the Android app name and optionally the android:host attribute in the AndroidManifest.xml file.
+///
+/// [appName] - The display name for the Android application. Must be a non-empty String.
+/// [customDirPath] - Optional custom directory path for the android/app folder, used in melos/microfrontend setups.
+///                   If provided and non-empty, replaces the default android/app directory path when locating the manifest file.
+/// [host] - Optional host value to set in the AndroidManifest.xml. If provided and non-empty, sets the android:host attribute.

Uh oh!

Feat: Add support custom_dir_path #88

Are you sure you want to change the base?

Feat: Add support custom_dir_path #88

Uh oh!

Conversation

malvinpratama commented Aug 26, 2025

Uh oh!

OutdatedGuy commented Aug 29, 2025

Uh oh!

malvinpratama commented Aug 31, 2025

Uh oh!

OutdatedGuy commented Aug 31, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants