Skip to content

Commit 9f67c57

Browse files
fix(ci): Update "deploy" Makefile target name to fix deployments of shared-data Python (#19201)
1 parent 5c13ce0 commit 9f67c57

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ deploy-py: export pypi_username = $(pypi_username)
131131
deploy-py: export pypi_password = $(pypi_password)
132132
deploy-py:
133133
$(MAKE) -C $(API_DIR) deploy
134-
$(MAKE) -C $(SHARED_DATA_DIR) deploy-py
134+
$(MAKE) -C $(SHARED_DATA_DIR) deploy
135135

136136
.PHONY: push-api
137137
push-api: export host = $(usb_host)

shared-data/Makefile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,13 @@ push-no-restart-ot3:
103103
push-ot3:
104104
$(MAKE) -f Makefile-python.mk push-ot3
105105

106-
.PHONY: deploy-py
107-
deploy-py:
106+
# NOTE: This Python-only recipe is intentionally generically named "deploy" as opposed
107+
# to something like "deploy-py". Our GitHub Actions workflows for Python projects
108+
# currently hard-code "deploy". If we add a JS deploy recipe to this Makefile, we
109+
# should probably rename this to "deploy-py" to avoid confusion, and reconsider the way
110+
# the GitHub Actions stuff works.
111+
.PHONY: deploy
112+
deploy:
108113
$(MAKE) -f Makefile-python.mk deploy
109114

110115
.PHONY: test-py

0 commit comments

Comments
 (0)