Skip to content

Commit 5c13ce0

Browse files
authored
fix(abr-testing): can't set pipette._last_tip_picked_up_from anymore (#19197)
# Overview Since PR #19061, `InstrumentContext._last_tip_picked_up_from` is no longer a property in the class, and can no longer be set. This change was causing the ABR tests trash_bin_tip_removal.py and waste_chute_tip_removal.py to fail, because they were trying to set `_last_tip_picked_up_from` to `None` after manually ejecting the tip via the hardware API. This fix just deletes the line `pipette._last_tip_picked_up_from = None`. The API will think that the pipette's tip came from wherever it came from, but since that info is only used for tip-return, and the test is not using tip-return, this is harmless. ## Test Plan and Hands on Testing See if CI builds successfully now. ## Risk assessment Low, should have no effect on the test's behavior.
1 parent d14c146 commit 5c13ce0

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

abr-testing/abr_testing/protocols/test_protocols/trash_bin_tip_removal.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ def drop_tip_with_ejector_extended(api: SyncHardwareAPI, mount: OT3Mount) -> Non
109109
"""Drop tip with pipette ejector extended."""
110110
move_pipette_plunger(api, mount, drop_tip_pos)
111111
api.remove_tip(mount)
112-
pipette._last_tip_picked_up_from = None
113112

114113
def clip_trash_edge() -> None:
115114
"""Knock tips off with trash bin edge."""

abr-testing/abr_testing/protocols/test_protocols/waste_chute_tip_removal.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ def drop_tip_with_ejector_extended(api: SyncHardwareAPI, mount: OT3Mount) -> Non
8787
"""Drop tip with pipette ejector extended."""
8888
move_pipette_plunger(api, mount, drop_tip_pos)
8989
api.remove_tip(mount)
90-
pipette._last_tip_picked_up_from = None
9190

9291
def clip_waste_chute_edge() -> None:
9392
"""Knock tips off with waste chute edge."""

0 commit comments

Comments
 (0)