Skip to content

Optimize VestingWallet _vestingSchedule to avoid redundant getter calls #6081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Optimize VestingWallet _vestingSchedule to avoid redundant getter calls #6081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/finance/VestingWallet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ contract VestingWallet is Context, Ownable {
* an asset given its total historical allocation.
*/
function _vestingSchedule(uint256 totalAllocation, uint64 timestamp) internal view virtual returns (uint256) {
if (timestamp < start()) {
if (timestamp < _start) {
return 0;
} else if (timestamp >= end()) {
} else if (timestamp >= _start + _duration) {
return totalAllocation;
} else {
return (totalAllocation * (timestamp - start())) / duration();
return (totalAllocation * (timestamp - _start)) / _duration;
}
}
}
Loading