Skip to content

Conversation

@Fibonacci747
Copy link
Contributor

@Fibonacci747 Fibonacci747 commented Nov 7, 2025

Remove the unused Strings import and using directive from ERC721URIStorage and ERC1155URIStorage. These extensions do not call Strings utilities; URI composition uses string.concat or defers to super where Strings is already used in the base contract. This reduces minor clutter without affecting behavior

@Fibonacci747 Fibonacci747 requested a review from a team as a code owner November 7, 2025 07:39
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: e03c2bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Walkthrough

The Strings library import and using Strings for uint256 directive have been removed from two URI storage extension contracts: ERC1155URIStorage.sol and ERC721URIStorage.sol. This eliminates the uint256 extension provided by the Strings library from both contracts. The public interfaces and token URI logic remain unchanged, continuing to handle tokenURI storage and base URI concatenation as before. Compilation now proceeds without the explicit Strings library dependency.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the purpose and scope of the changes, detailing which files are affected and why the Strings import is unnecessary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title 'Cleanup: remove unused import and "using for"' directly and accurately summarizes the main change: removing unused Strings import and using directives from the two storage contracts.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx changed the title fix: remove unused strings in uri storage Cleanup: remove unused import and "using for" Nov 10, 2025
@Amxx Amxx merged commit 806165f into OpenZeppelin:master Nov 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants