Skip to content

Defer signer() reads until after tryDecodeAuth success in SignerWebAuthn #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

Defer signer() reads until after tryDecodeAuth success in SignerWebAuthn #6070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions contracts/utils/cryptography/signers/SignerWebAuthn.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ abstract contract SignerWebAuthn is SignerP256 {
bytes32 hash,
bytes calldata signature
) internal view virtual override returns (bool) {
(bytes32 qx, bytes32 qy) = signer();
(bool decodeSuccess, WebAuthn.WebAuthnAuth calldata auth) = WebAuthn.tryDecodeAuth(signature);

return
decodeSuccess
? WebAuthn.verify(abi.encodePacked(hash), auth, qx, qy)
: super._rawSignatureValidation(hash, signature);
if (decodeSuccess) {
(bytes32 qx, bytes32 qy) = signer();
return WebAuthn.verify(abi.encodePacked(hash), auth, qx, qy);
} else {
return super._rawSignatureValidation(hash, signature);
}
}
}
Loading