-
Notifications
You must be signed in to change notification settings - Fork 397
feat: implement ERC-6909 multi-token standard (continuation of #1040) #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed much of the logic for these extensions from the `ERC6909Component`. Now these are different components. Reason for this was to keep the original code as small as possible as metadata, supply and uri are not part of the EIP, but are just optional extensions
|
Hey @lumoswiz! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
==========================================
+ Coverage 92.36% 92.60% +0.24%
==========================================
Files 85 86 +1
Lines 2278 2325 +47
==========================================
+ Hits 2104 2153 +49
+ Misses 174 172 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@bidzyyys Updated docs & have CI passing now. I need some advice/feedback on the following:
Let me know what you think, and I can make the changes if appropriate. |
This PR continues the work started in #1040 by @swan-of-bodom, implementing the ERC-6909 multi-token standard for Cairo.
It rebases that branch on top of the latest
main, resolves merge conflicts, modernizes the code to align with current Cairo and OpenZeppelin patterns, and adds missing tests and documentation.Fixes #1570
Summary of changes
metadata,supply, andURIextensions and integrates them withERC6909.with_components!(ERC6909, ...).Context
The original PR (#1040) had gone stale for over a year.
This branch preserves @swan-of-bodom’s commits and authorship while bringing the implementation up to date with current Cairo contracts.
PR Checklist
Co-authored-by: @swan-of-bodom