Skip to content

Allow list for refers_to rule #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Allow list for refers_to rule #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions qc_ositrace/checks/osirules/osirules_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,17 +405,17 @@ def check_message_against_rules(
description=f"Field '{field.name}' value {value.value} in message '{message.DESCRIPTOR.full_name}' does not refer to any existing message.",
)
else:
# Check if referred message matches the expected type
expected_type = f"""osi3.{rule['refers_to'].strip("'")}"""
if referred_message.DESCRIPTOR.full_name != expected_type:
# Check if referred message matches one of the expected types
expected_types = ["osi3." + t for t in rule['refers_to']] if isinstance(rule['refers_to'], list) else ["osi3." + rule['refers_to']]
if referred_message.DESCRIPTOR.full_name not in expected_types:
register_issue(
result,
message,
index,
time,
rule_uid,
IssueSeverity.ERROR,
description=f"Field '{field.name}' value {value.value} in message '{message.DESCRIPTOR.full_name}' refers to message '{referred_message.DESCRIPTOR.full_name}', which does not match the expected type '{expected_type}'.",
description=f"Field '{field.name}' value {value.value} in message '{message.DESCRIPTOR.full_name}' refers to message '{referred_message.DESCRIPTOR.full_name}', which does not match one of the expected types '{expected_types}'.",
)

# Recursively check nested messages
Expand Down