Skip to content

Conversation

@FabianPfeuffer
Copy link

Add a description

This pull request makes the definition of free boundaries for lanes more concrete.
It suggests that the free boundaries of an intersection lane should follow a general definition direction (in this case clockwise)

Some questions to ask:
What is this change?

  • Documentation/Definition

What does it fix?

  • This commit improves the vague definition of the free boundaries. With the current definition of the free boundaries, it is very difficult to e.g. create a closed polygon or mesh for OSI intersection lanes.

Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?

  • Only a fix/improvement of the documentation, no update or new version is needed

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@yash-shah-asam
Copy link
Member

@thomassedlmayer could you please discuss this in the sensor modeling project meeting?

@pmai pmai added this to the V3.7.1 milestone Apr 10, 2025
@pmai
Copy link
Contributor

pmai commented Apr 10, 2025

@tbleher you might also have an opinion on whether this is a correct/useful clarification.

@thomassedlmayer thomassedlmayer added the SensorModeling The Group in the ASAM development project working on sensor modeling topics. label Apr 10, 2025
// \note \c Lane with \c #type = \c #TYPE_INTERSECTION use only free
// lane boundaries.
//
// \note Free boundaries should be defined in clockwise direction. The starting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only about the definition order of the boundary points or also about the order of referencing free lane boundaries in the list (e.g. [11, 14, 13, 12]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SensorModeling The Group in the ASAM development project working on sensor modeling topics.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants