-
Notifications
You must be signed in to change notification settings - Fork 130
Feature/tp/had output #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0ba6b51
Add top-level motion request message
lemmer-fzi 7637bf3
Make MotionRequest positions and orientations 3D
lemmer-fzi 1ee24bc
Linguistic review of MotionRequest
paagkame 891a0d7
Add missing explanation of desired state message
lemmer-fzi 592981c
Linguistic review of MotionRequest
paagkame e13dfd5
Restructure MotionRequest message based on review
Krishna626 5c4b575
Adjust MotionRequest to match OSI guidelines
Krishna626 ade69b5
Fix typos in MotionRequest message
max-rosin 1508eca
Add osi_motionrequest.proto to CMakeFile and setup.py
lemmer-fzi d439267
Fix minor typos, reflow comments on MotionRequest
max-rosin 2f63254
Adjust names per conventions in MotionRequest
lemmer-fzi e738f12
Remove explicit reference to HAD function, clarify intent
lemmer-fzi 98d033c
Rename enum types to comply with naming conventions
lemmer-fzi e553528
Change reference point to middle of the rear axis
lemmer-fzi bfe758b
Add additional note to trajectory point in desired trajectory
lemmer-fzi 879aa0d
Update local build tools
philipwindecker 2ff03e6
Fix paths in _config.adoc for local previews
philipwindecker a3b4d50
Update pictures and documentation for MotionRequest
lemmer-fzi 2893ff2
Apply suggestions from code review
pmai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| ifndef::include-only-once[] | ||
| :root-path: ../ | ||
| include::{root-path}_config.adoc[] | ||
| endif::[] | ||
| = Motion Request | ||
|
|
||
| `MotionRequest` messages are traffic participant internal messages. | ||
| They function as a interface between a motion/behavior planning model and a dynamics model including, for example, controllers and vehicle kinematics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| syntax = "proto2"; | ||
|
|
||
| option optimize_for = SPEED; | ||
|
|
||
| import "osi_common.proto"; | ||
| import "osi_version.proto"; | ||
|
|
||
| package osi3; | ||
|
|
||
| // | ||
| // \brief This message is intended as an interface between a | ||
| // motion-planning function and the actuator management. | ||
| // The motion-planning function can thereby be a representation of a | ||
| // highly-automated driving function, a human driving behavior model, etc. | ||
| // | ||
| // The motion-planning function can either send a desired future trajectory or a desired | ||
| // future state. The message can be defined by an additional variable. | ||
| // | ||
| // \note The coordinate system is defined as right-handed. | ||
| // All coordinates and orientations are relative to the global coordinate system. | ||
| // The reference point of the vehicle is the middle of the rear axis. | ||
| // Units are m for positions, m/s for velocities, and m/s^2 for accelerations. | ||
| // | ||
| message MotionRequest | ||
| { | ||
| // The interface version used by the sender (simulation environment). | ||
| // | ||
| optional InterfaceVersion version = 1; | ||
|
|
||
| // The data timestamp of the simulation environment. | ||
| // A reference to \c Timestamp message. | ||
| // | ||
| optional Timestamp timestamp = 2; | ||
|
|
||
| // Define the type that is used to specify the motion request. | ||
| // This must be set. Additionally, the field corresponding to the specified | ||
| // option must be set. | ||
| // | ||
| optional MotionRequestType motion_request_type = 3; | ||
|
|
||
| // Defines a desired state. | ||
| // If the output option is set to DESIRED_STATE, this field must be set. | ||
| // | ||
| optional DesiredState desired_state = 4; | ||
|
|
||
| // Defines a desired trajectory. | ||
| // If the output option is set to DESIRED_TRAJECTORY, this field must be set. | ||
| // | ||
| optional DesiredTrajectory desired_trajectory = 5; | ||
|
|
||
| // Define different options for function output. | ||
| // Each option corresponds to a field in the message. | ||
| // | ||
| enum MotionRequestType | ||
| { | ||
| // Desired state calculated by the function. | ||
| // | ||
| MOTION_REQUEST_TYPE_DESIRED_STATE = 0; | ||
|
|
||
| // Desired trajectory calculated by the function. | ||
| // | ||
| MOTION_REQUEST_TYPE_TRAJECTORY = 1; | ||
| } | ||
|
|
||
| // \brief The desired state is calculated by the function as a result of | ||
| // the motion planning stack. | ||
| // | ||
| // The actuator management is supposed to reach the desired state at the | ||
| // specified time. | ||
| // | ||
| message DesiredState | ||
| { | ||
| // A reference to \c Timestamp message. | ||
| // | ||
| optional Timestamp timestamp = 1; | ||
ThomasNaderBMW marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Intended position to be reached in in x-, y-, and z-direction. | ||
| // | ||
| optional Vector3d position = 2; | ||
|
|
||
| // Intended orientation to be reached containing yaw, pitch and roll angle. | ||
| // | ||
| optional Orientation3d orientation = 3; | ||
|
|
||
| // Intended velocity to be reached in in x-, y-, and z-direction. | ||
| // | ||
| // Unit: m/s | ||
| // | ||
| optional Vector3d velocity = 4; | ||
|
|
||
| // Intended acceleration to be reached in x-, y-, and z-direction. | ||
| // | ||
| // Unit: m/s^2 | ||
| // | ||
| optional Vector3d acceleration = 5; | ||
| } | ||
|
|
||
| // \brief Defined trajectory desired by the function. | ||
| // | ||
| // This trajectory is the result of the trajectory planning step in the function. | ||
| // The task of the actuator management is to follow this trajectory as closely as possible. | ||
| // The timestamps inside the trajectory must be defined in global simulation time. | ||
| // | ||
ThomasNaderBMW marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // \note The trajectory is kept as a separate message for future extensions. | ||
| // | ||
| message DesiredTrajectory | ||
| { | ||
| // The trajectory consists of intended position (x, y, and z) and | ||
| // orientation (yaw, pitch and roll) of intended state to be reached. | ||
| // A reference to \c StatePoint message. | ||
| // | ||
| // \note The position within the trajectory point references to the | ||
| // middle point of the rear axis. | ||
| // | ||
| repeated StatePoint trajectory_point = 1; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.