Fix memory allocation/deallocation mismatch in fuzz_array.c #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fuzzer was using C's free() to deallocate memory allocated with C++'s new[] operator, causing an immediate crash when built with AddressSanitizer: ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs free) This prevents the fuzzer from running and testing CUPS array functionality. Root cause: - Memory allocated with new[] in fuzz_helpers.cpp (lines 21, 24) - Memory freed with free() in fuzz_array.c (lines 161-162) - C++ requires new[] to be paired with delete[], not free() Fix: Replace incorrect free() calls with the existing free_fuzz_array_data() helper function that properly uses delete[] operator. This allows the fuzzer to run successfully and test CUPS code without immediate crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzzer was using C's free() to deallocate memory allocated with C++'s new[] operator, causing an immediate crash when built with AddressSanitizer:
ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs free)
This prevents the fuzzer from running and testing CUPS array functionality.
Root cause:
Fix:
Replace incorrect free() calls with the existing free_fuzz_array_data() helper function that properly uses delete[] operator.
This allows the fuzzer to run successfully and test CUPS code without immediate crashes.