-
Notifications
You must be signed in to change notification settings - Fork 3
Feat/ga checks #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/ga_consistency
Are you sure you want to change the base?
Feat/ga checks #127
Conversation
kvdblom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small change, otherwise looks good!
| workflow_dispatch: # allow triggering workflow manually | ||
| inputs: | ||
| reason: | ||
| description: "Reason for Running" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to have a more informative description, maybe something like: "Automatically checking formatting."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the input prompt. You are supposed to input your reason for running 😉
|
Looks good, only merge after: #114 |
Adds the GitHub Action responsible for triggering the validation of the new problem
Note that this check is only supposed to be triggered when the template file "new_problem.yaml" is changed. It will mark a failure if the name is not changed, that's why the test currently fails here.
Closes #124