Skip to content

Conversation

@ak684
Copy link

@ak684 ak684 commented Nov 4, 2025


Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.12-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:e357c90-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-e357c90-python \
  ghcr.io/openhands/agent-server:e357c90-python

All tags pushed for this build

ghcr.io/openhands/agent-server:e357c90-golang-amd64
ghcr.io/openhands/agent-server:e357c90-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:e357c90-golang-arm64
ghcr.io/openhands/agent-server:e357c90-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:e357c90-java-amd64
ghcr.io/openhands/agent-server:e357c90-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:e357c90-java-arm64
ghcr.io/openhands/agent-server:e357c90-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:e357c90-python-amd64
ghcr.io/openhands/agent-server:e357c90-nikolaik_s_python-nodejs_tag_python3.12-nodejs22-amd64
ghcr.io/openhands/agent-server:e357c90-python-arm64
ghcr.io/openhands/agent-server:e357c90-nikolaik_s_python-nodejs_tag_python3.12-nodejs22-arm64
ghcr.io/openhands/agent-server:e357c90-golang
ghcr.io/openhands/agent-server:e357c90-java
ghcr.io/openhands/agent-server:e357c90-python

About Multi-Architecture Support

  • Each variant tag (e.g., e357c90-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., e357c90-python-amd64) are also available if needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
openhands-sdk/openhands/sdk/llm
   llm.py45618958%324, 328, 333, 337, 341, 345–347, 351–352, 363–364, 366–367, 371, 388, 417, 422, 426, 431, 451, 480, 501, 505, 520, 526–527, 546–547, 557, 582–587, 608–609, 612, 616, 628, 633–636, 643, 646, 654–659, 663–666, 668, 683, 687–689, 691–692, 697–698, 700, 707, 710–715, 785–788, 793–797, 799–804, 806–808, 817–819, 822–823, 869–870, 873–876, 917, 931, 981, 984–986, 989–997, 1001–1003, 1006, 1009–1011, 1018–1019, 1028, 1035–1037, 1041–1042, 1044–1049, 1051–1059, 1061–1081, 1084–1088, 1090–1091, 1097–1106, 1119, 1133, 1138
openhands-sdk/openhands/sdk/llm/utils
   telemetry.py1748650%109, 115, 124, 128, 131, 136–137, 172, 176, 183, 205, 209–210, 218–220, 226, 243–245, 247–249, 251, 259–260, 264–266, 269–272, 277, 282, 285, 290, 293, 299, 305, 307, 310–311, 316, 321–325, 329–336, 338–339, 343–347, 351–354, 358–362, 366–369, 373, 380–381, 384, 386, 389–392
TOTAL12098559053% 

"""Test that ssl_verify is correctly parsed from environment variables."""
# Test various false values
for value in ["false", "False", "FALSE", "0", "no", "off"]:
os.environ["LLM_SSL_VERIFY"] = value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OpenHands there's some monkeypatch env in pytest, which cleans up itself, for use in testing. You know what I mean. Adjust this test a bit to use it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it! enyst can track my progress at all-hands.dev

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of changes

What I updated

  • File: tests/sdk/llm/test_llm.py
  • Test updated: test_llm_ssl_verify_env_parsing
    • Switched from direct os.environ manipulation to pytest’s monkeypatch.setenv for environment variables.
    • Set LLM_MODEL once via monkeypatch for all load_from_env calls in the test.
    • Removed manual cleanup of environment variables and the now-unused os import.

Why

  • Per the PR comment, this uses pytest’s monkeypatch fixture which automatically restores environment state after the test, improving isolation and avoiding side effects.

Verification

  • Pre-commit on the changed file: passed (ruff format/lint, pycodestyle, pyright).
  • Ran the specific test: uv run pytest -q tests/sdk/llm/test_llm.py::test_llm_ssl_verify_env_parsing → 1 passed.

Checklist

  • Addressed the request to use pytest’s env monkeypatch.
  • Kept the change minimal: only modified the relevant test and removed an unused import.
  • Followed repo dev/test guidelines (pre-commit hooks, no mypy, minimal changes).
  • Committed only the changed test file with Co-authored-by and pushed to the current branch.

Commit

  • tests(llm): use pytest monkeypatch for env vars in ssl_verify parsing test
  • Branch: alona/all-4119-add-enterprise-gateway-support-for-llm-providers-in-cli-v3

If you want, I can sweep other tests for os.environ usage and convert them to monkeypatch as well.

View full conversation

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note, the docs check is not mandatory. It's there just to remind us to make a docs PR (the agent should know what to do if we tell it to do something similar to the other examples)

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Nov 10, 2025

[Automatic Post]: It has been a while since there was any activity on this PR. @ak684, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

@ak684 ak684 force-pushed the alona/all-4119-add-enterprise-gateway-support-for-llm-providers-in-cli-v3 branch from 405f710 to 878c17d Compare November 11, 2025 18:00
- Fix line length issues in enterprise gateway example
- Update imports to use get_default_agent instead of Agent directly
- Remove try/finally block and conversation.close() call to match SDK patterns
@ak684 ak684 force-pushed the alona/all-4119-add-enterprise-gateway-support-for-llm-providers-in-cli-v3 branch from 878c17d to 45aafa7 Compare November 11, 2025 19:18
@openhands-ai
Copy link

openhands-ai bot commented Nov 11, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Check Documented Examples

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #1026 at branch `alona/all-4119-add-enterprise-gateway-support-for-llm-providers-in-cli-v3`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Nov 18, 2025

[Automatic Post]: It has been a while since there was any activity on this PR. @ak684, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants